Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 14328019: Some first_run code cleanups (extracted from https://codereview.chromium.org/12670013 to keep that … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r196136 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/first_run/first_run.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index d600b6431d603937f6e9f4eab2915d60b5933d3f..6f0d66ffc986c1e83e2c32a37f7020310be6d339 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -903,9 +903,12 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {
prefs::kBrowserSuppressDefaultBrowserPrompt,
master_prefs_->suppress_default_browser_prompt_for_version);
}
- } else if (parsed_command_line().HasSwitch(switches::kNoFirstRun)) {
- // Create the First Run beacon anyways if --no-first-run was passed on the
- // command line.
+ }
+
+ if (do_first_run_tasks_ ||
+ parsed_command_line().HasSwitch(switches::kNoFirstRun)) {
+ // Create the First Run sentinel whether first run tasks are executed
+ // or not.
first_run::CreateSentinel();
}
}
« no previous file with comments | « no previous file | chrome/browser/first_run/first_run.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698