Send any logError() information to the IDE.

Send any logError() information to the IDE.

I have not seen any errors sent so far after several minutes of playing with it.
Adding and removing files does not cause any errors.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5b61845221b0d40f31edf5cfc2155e2253b2aa72

[Brian Wilkerson, 2015-11-12 14:52:51]

LGTM after adding messages

https://codereview.chromium.org/1432423004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_logger.dart (right):

https://codereview.chromium.org/1432423004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_logger.dart:28:
AnalysisLogger({this.onError}) {
I'm not sure we need this level of flexibility. Seems like it would be cleaner
to just pass in the server and then invoke sendNotification directly. Your call.

https://codereview.chromium.org/1432423004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1432423004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:719:
sendServerErrorNotification(null, exception, stackTrace, fatal: true);
I think we should always provide a message that identifies where the exception
occurred and any additional information we might want in order to debug it. For
example, in this place we could include the request that caused the exception:

   "Failed to handle request: ${request.toJson()}"

[scheglov, 2015-11-12 16:15:56]

https://codereview.chromium.org/1432423004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_logger.dart (right):

https://codereview.chromium.org/1432423004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_logger.dart:28:
AnalysisLogger({this.onError}) {
On 2015/11/12 14:52:51, Brian Wilkerson wrote:
> I'm not sure we need this level of flexibility. Seems like it would be cleaner
> to just pass in the server and then invoke sendNotification directly. Your
call.

Done.

https://codereview.chromium.org/1432423004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1432423004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:719:
sendServerErrorNotification(null, exception, stackTrace, fatal: true);
On 2015/11/12 14:52:51, Brian Wilkerson wrote:
> I think we should always provide a message that identifies where the exception
> occurred and any additional information we might want in order to debug it.
For
> example, in this place we could include the request that caused the exception:
> 
>    "Failed to handle request: ${request.toJson()}"

Done.

[scheglov, 2015-11-12 16:16:31]

Committed patchset #2 (id:20001) manually as
5b61845221b0d40f31edf5cfc2155e2253b2aa72 (presubmit successful).