Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: pkg/analyzer/lib/task/model.dart

Issue 1432423004: Send any logError() information to the IDE. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add messages for all sendServerErrorNotification() invocations. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.task.model; 5 library analyzer.task.model;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 import 'dart:developer'; 8 import 'dart:developer';
9 9
10 import 'package:analyzer/src/generated/engine.dart' hide AnalysisTask; 10 import 'package:analyzer/src/generated/engine.dart' hide AnalysisTask;
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 * this task is expected to produce) or the [caughtException] should be set. 204 * this task is expected to produce) or the [caughtException] should be set.
205 * 205 *
206 * Clients may not override this method. 206 * Clients may not override this method.
207 */ 207 */
208 void perform() { 208 void perform() {
209 try { 209 try {
210 _safelyPerform(); 210 _safelyPerform();
211 } on AnalysisException catch (exception, stackTrace) { 211 } on AnalysisException catch (exception, stackTrace) {
212 caughtException = new CaughtException(exception, stackTrace); 212 caughtException = new CaughtException(exception, stackTrace);
213 AnalysisEngine.instance.logger 213 AnalysisEngine.instance.logger
214 .logInformation("Task failed: ${description}", caughtException); 214 .logError("Task failed: ${description}", caughtException);
215 } 215 }
216 } 216 }
217 217
218 @override 218 @override
219 String toString() => description; 219 String toString() => description;
220 220
221 /** 221 /**
222 * Given a strongly connected component, find and return a list of 222 * Given a strongly connected component, find and return a list of
223 * [TargetedResult]s that describes a cyclic path within the cycle. Returns 223 * [TargetedResult]s that describes a cyclic path within the cycle. Returns
224 * null if no cyclic path is found. 224 * null if no cyclic path is found.
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 /** 735 /**
736 * A work should be done, but without any special urgency. 736 * A work should be done, but without any special urgency.
737 */ 737 */
738 NORMAL, 738 NORMAL,
739 739
740 /** 740 /**
741 * Nothing to do. 741 * Nothing to do.
742 */ 742 */
743 NONE 743 NONE
744 } 744 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698