pkg/analysis_server/lib/src/domain_completion.dart - Issue 1432423004: Send any logError() information to the IDE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 1432423004: Send any logError() information to the IDE. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add messages for all sendServerErrorNotification() invocations. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/domain_completion.dart

diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart

index e20473263d073bf4f9d3bdde23a27b85f512866c..6d43e5324e92d164987e75c708e67740c1ea2e2b 100644

--- a/pkg/analysis_server/lib/src/domain_completion.dart

+++ b/pkg/analysis_server/lib/src/domain_completion.dart

@@ -142,7 +142,10 @@ class CompletionDomainHandler implements RequestHandler {

}

return null;

}, onError: (exception, stackTrace) {

- server.sendServerErrorNotification(exception, stackTrace);

+ server.sendServerErrorNotification(

+ 'Failed to handle completion domain request: ${request.toJson()}',

+ exception,

+ stackTrace);

});

}