Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/analysis_server/lib/src/analysis_logger.dart

Issue 1432423004: Send any logError() information to the IDE. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add messages for all sendServerErrorNotification() invocations. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/analysis_server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_logger.dart
diff --git a/pkg/analysis_server/lib/src/analysis_logger.dart b/pkg/analysis_server/lib/src/analysis_logger.dart
index 9e751a42661dde5c5ca733094661778af6d935ad..04ad6c6f6e90bf80b394bfe5c0b3c1d90a554a17 100644
--- a/pkg/analysis_server/lib/src/analysis_logger.dart
+++ b/pkg/analysis_server/lib/src/analysis_logger.dart
@@ -4,6 +4,7 @@
library analysis.logger;
+import 'package:analysis_server/src/analysis_server.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/java_engine.dart';
import 'package:logging/logging.dart' as logging;
@@ -18,7 +19,13 @@ class AnalysisLogger implements Logger {
*/
final logging.Logger baseLogger = new logging.Logger('analysis.server');
- AnalysisLogger() {
+ /**
+ * The analysis server that is using this logger.
+ */
+ final AnalysisServer server;
+
+ AnalysisLogger(this.server) {
+ assert(server != null);
logging.Logger.root.onRecord.listen((logging.LogRecord record) {
AnalysisEngine.instance.instrumentationService.logLogEntry(
record.level.name,
@@ -36,6 +43,8 @@ class AnalysisLogger implements Logger {
} else {
baseLogger.severe(message, exception.exception, exception.stackTrace);
}
+ server.sendServerErrorNotification(
+ message, exception, exception?.stackTrace);
}
@override
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/analysis_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698