Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1432243003: Oilpan: move DateTimeChooser to the heap. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: move DateTimeChooser to the heap. Done so as to allow DateTimeChooserImpl::m_chromeClient to be correctly traced, but consistent to have this on the heap alongside the other 'chooser' object, ColorChooser. R=haraken BUG=553613 Committed: https://crrev.com/13b31390e406a7fc71feed27eec660f5086cb28a Cr-Commit-Position: refs/heads/master@{#359321}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
sof
5 years, 1 month ago (2015-11-12 10:43:56 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-12 14:26:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432243003/1
5 years, 1 month ago (2015-11-12 14:54:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 15:25:50 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:07:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13b31390e406a7fc71feed27eec660f5086cb28a
Cr-Commit-Position: refs/heads/master@{#359321}

Powered by Google App Engine
This is Rietveld 408576698