Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: third_party/WebKit/Source/web/DateTimeChooserImpl.h

Issue 1432243003: Oilpan: move DateTimeChooser to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/DateTimeChooserImpl.h
diff --git a/third_party/WebKit/Source/web/DateTimeChooserImpl.h b/third_party/WebKit/Source/web/DateTimeChooserImpl.h
index 07cce095ea7ff011dd22c765de2fba4218edee93..ab0db163f2dc96a3ecc9f436e3b47a4327b5ef0a 100644
--- a/third_party/WebKit/Source/web/DateTimeChooserImpl.h
+++ b/third_party/WebKit/Source/web/DateTimeChooserImpl.h
@@ -43,13 +43,15 @@ class PagePopup;
class DateTimeChooserImpl final : public DateTimeChooser, public PagePopupClient {
public:
- static PassRefPtr<DateTimeChooserImpl> create(ChromeClientImpl*, DateTimeChooserClient*, const DateTimeChooserParameters&);
+ static PassRefPtrWillBeRawPtr<DateTimeChooserImpl> create(ChromeClientImpl*, DateTimeChooserClient*, const DateTimeChooserParameters&);
~DateTimeChooserImpl() override;
// DateTimeChooser functions:
void endChooser() override;
AXObject* rootAXObject() override;
+ DECLARE_VIRTUAL_TRACE();
+
private:
DateTimeChooserImpl(ChromeClientImpl*, DateTimeChooserClient*, const DateTimeChooserParameters&);
// PagePopupClient functions:
@@ -63,7 +65,7 @@ private:
Element& ownerElement() override;
void didClosePopup() override;
- ChromeClientImpl* m_chromeClient;
+ RawPtrWillBeMember<ChromeClientImpl> m_chromeClient;
DateTimeChooserClient* m_client;
PagePopup* m_popup;
DateTimeChooserParameters m_parameters;
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.cpp ('k') | third_party/WebKit/Source/web/DateTimeChooserImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698