Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

Issue 1432243003: Oilpan: move DateTimeChooser to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
diff --git a/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp b/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
index 670f97a698355787208dfe17b9f0e154907c691f..789345dda59177efebd38aa1d25b0e016408a39e 100644
--- a/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
+++ b/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
@@ -58,15 +58,21 @@ DateTimeChooserImpl::DateTimeChooserImpl(ChromeClientImpl* chromeClient, DateTim
m_popup = m_chromeClient->openPagePopup(this);
}
-PassRefPtr<DateTimeChooserImpl> DateTimeChooserImpl::create(ChromeClientImpl* chromeClient, DateTimeChooserClient* client, const DateTimeChooserParameters& parameters)
+PassRefPtrWillBeRawPtr<DateTimeChooserImpl> DateTimeChooserImpl::create(ChromeClientImpl* chromeClient, DateTimeChooserClient* client, const DateTimeChooserParameters& parameters)
{
- return adoptRef(new DateTimeChooserImpl(chromeClient, client, parameters));
+ return adoptRefWillBeNoop(new DateTimeChooserImpl(chromeClient, client, parameters));
}
DateTimeChooserImpl::~DateTimeChooserImpl()
{
}
+DEFINE_TRACE(DateTimeChooserImpl)
+{
+ visitor->trace(m_chromeClient);
+ DateTimeChooser::trace(visitor);
+}
+
void DateTimeChooserImpl::endChooser()
{
if (!m_popup)
@@ -184,7 +190,7 @@ Locale& DateTimeChooserImpl::locale()
void DateTimeChooserImpl::setValueAndClosePopup(int numValue, const String& stringValue)
{
- RefPtr<DateTimeChooserImpl> protector(this);
+ RefPtrWillBeRawPtr<DateTimeChooserImpl> protector(this);
if (numValue >= 0)
setValue(stringValue);
endChooser();
« no previous file with comments | « third_party/WebKit/Source/web/DateTimeChooserImpl.h ('k') | third_party/WebKit/Source/web/ExternalDateTimeChooser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698