Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1432243003: Oilpan: move DateTimeChooser to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 notifyPopupOpeningObservers(); 596 notifyPopupOpeningObservers();
597 OwnPtrWillBeRawPtr<ColorChooserUIController> controller = nullptr; 597 OwnPtrWillBeRawPtr<ColorChooserUIController> controller = nullptr;
598 if (RuntimeEnabledFeatures::pagePopupEnabled()) 598 if (RuntimeEnabledFeatures::pagePopupEnabled())
599 controller = ColorChooserPopupUIController::create(frame, this, chooserC lient); 599 controller = ColorChooserPopupUIController::create(frame, this, chooserC lient);
600 else 600 else
601 controller = ColorChooserUIController::create(frame, chooserClient); 601 controller = ColorChooserUIController::create(frame, chooserClient);
602 controller->openUI(); 602 controller->openUI();
603 return controller.release(); 603 return controller.release();
604 } 604 }
605 605
606 PassRefPtr<DateTimeChooser> ChromeClientImpl::openDateTimeChooser(DateTimeChoose rClient* pickerClient, const DateTimeChooserParameters& parameters) 606 PassRefPtrWillBeRawPtr<DateTimeChooser> ChromeClientImpl::openDateTimeChooser(Da teTimeChooserClient* pickerClient, const DateTimeChooserParameters& parameters)
607 { 607 {
608 notifyPopupOpeningObservers(); 608 notifyPopupOpeningObservers();
609 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 609 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
610 return DateTimeChooserImpl::create(this, pickerClient, parameters); 610 return DateTimeChooserImpl::create(this, pickerClient, parameters);
611 #else 611 #else
612 return ExternalDateTimeChooser::create(this, m_webView->client(), pickerClie nt, parameters); 612 return ExternalDateTimeChooser::create(this, m_webView->client(), pickerClie nt, parameters);
613 #endif 613 #endif
614 } 614 }
615 615
616 void ChromeClientImpl::openFileChooser(LocalFrame* frame, PassRefPtr<FileChooser > fileChooser) 616 void ChromeClientImpl::openFileChooser(LocalFrame* frame, PassRefPtr<FileChooser > fileChooser)
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 if (m_webView->pageImportanceSignals()) 1009 if (m_webView->pageImportanceSignals())
1010 m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript(); 1010 m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript();
1011 } 1011 }
1012 1012
1013 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler() 1013 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler()
1014 { 1014 {
1015 return m_webView->scheduler()->createFrameScheduler().release(); 1015 return m_webView->scheduler()->createFrameScheduler().release();
1016 } 1016 }
1017 1017
1018 } // namespace blink 1018 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/DateTimeChooserImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698