Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14320005: Revert 194993 "Remove reference counting from media::VideoDecode..." (Closed)

Created:
7 years, 8 months ago by scherkus (not reviewing)
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194993 "Remove reference counting from media::VideoDecode..." > Remove reference counting from media::VideoDecoder and friends. > > In addition: > * VideoRenderer is now passed a list of decoders via constructor instead of Initialize() > * WebMediaPlayerImpl's FilterCollection is now built in one shot instead of incrementally > > BUG=173313 > > Review URL: https://codereview.chromium.org/12989009 TBR=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -442 lines) Patch
MM trunk/src/media/base/filter_collection.h View 4 chunks +8 lines, -0 lines 0 comments Download
M trunk/src/media/base/filter_collection.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M trunk/src/media/base/mock_filters.h View 1 chunk +10 lines, -9 lines 0 comments Download
M trunk/src/media/base/pipeline.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/media/base/pipeline_unittest.cc View 5 chunks +18 lines, -9 lines 0 comments Download
M trunk/src/media/base/video_decoder.h View 3 chunks +7 lines, -5 lines 0 comments Download
M trunk/src/media/base/video_renderer.h View 4 chunks +7 lines, -2 lines 0 comments Download
M trunk/src/media/filters/decrypting_video_decoder.h View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/filters/decrypting_video_decoder.cc View 8 chunks +6 lines, -8 lines 0 comments Download
M trunk/src/media/filters/decrypting_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/filters/ffmpeg_video_decoder.h View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/filters/ffmpeg_video_decoder.cc View 3 chunks +1 line, -4 lines 0 comments Download
M trunk/src/media/filters/ffmpeg_video_decoder_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/media/filters/gpu_video_decoder.h View 6 chunks +5 lines, -14 lines 0 comments Download
M trunk/src/media/filters/gpu_video_decoder.cc View 18 chunks +68 lines, -156 lines 0 comments Download
M trunk/src/media/filters/pipeline_integration_test_base.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M trunk/src/media/filters/video_decoder_selector.h View 4 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/media/filters/video_decoder_selector.cc View 5 chunks +42 lines, -35 lines 0 comments Download
M trunk/src/media/filters/video_decoder_selector_unittest.cc View 12 chunks +30 lines, -26 lines 0 comments Download
M trunk/src/media/filters/video_frame_stream.h View 4 chunks +9 lines, -6 lines 0 comments Download
M trunk/src/media/filters/video_frame_stream.cc View 7 chunks +21 lines, -9 lines 0 comments Download
M trunk/src/media/filters/video_frame_stream_unittest.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M trunk/src/media/filters/video_renderer_base.h View 5 chunks +1 line, -9 lines 0 comments Download
M trunk/src/media/filters/video_renderer_base.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/media/filters/video_renderer_base_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/media/filters/vpx_video_decoder.h View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/filters/vpx_video_decoder.cc View 3 chunks +1 line, -3 lines 0 comments Download
M trunk/src/media/tools/player_x11/player_x11.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + trunk/src/webkit/media/filter_helpers.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/webkit/media/filter_helpers.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/webkit/media/webkit_media.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/webkit/media/webmediaplayer_impl.h View 4 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/webkit/media/webmediaplayer_impl.cc View 11 chunks +46 lines, -88 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
7 years, 8 months ago (2013-04-18 22:02:13 UTC) #1
scherkus (not reviewing)
7 years, 8 months ago (2013-04-18 22:03:52 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r195013.

Powered by Google App Engine
This is Rietveld 408576698