Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: trunk/src/media/filters/video_renderer_base.cc

Issue 14320005: Revert 194993 "Remove reference counting from media::VideoDecode..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/media/filters/video_renderer_base.cc
===================================================================
--- trunk/src/media/filters/video_renderer_base.cc (revision 195011)
+++ trunk/src/media/filters/video_renderer_base.cc (working copy)
@@ -23,15 +23,14 @@
VideoRendererBase::VideoRendererBase(
const scoped_refptr<base::MessageLoopProxy>& message_loop,
- ScopedVector<VideoDecoder> decoders,
const SetDecryptorReadyCB& set_decryptor_ready_cb,
const PaintCB& paint_cb,
const SetOpaqueCB& set_opaque_cb,
bool drop_frames)
: message_loop_(message_loop),
weak_factory_(this),
- video_frame_stream_(new VideoFrameStream(
- message_loop, decoders.Pass(), set_decryptor_ready_cb)),
+ video_frame_stream_(new VideoFrameStream(message_loop,
+ set_decryptor_ready_cb)),
received_end_of_stream_(false),
frame_available_(&lock_),
state_(kUninitialized),
@@ -137,6 +136,7 @@
}
void VideoRendererBase::Initialize(const scoped_refptr<DemuxerStream>& stream,
+ const VideoDecoderList& decoders,
const PipelineStatusCB& init_cb,
const StatisticsCB& statistics_cb,
const TimeCB& max_time_cb,
@@ -148,6 +148,7 @@
DCHECK(message_loop_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
DCHECK(stream);
+ DCHECK(!decoders.empty());
DCHECK_EQ(stream->type(), DemuxerStream::VIDEO);
DCHECK(!init_cb.is_null());
DCHECK(!statistics_cb.is_null());
@@ -171,6 +172,7 @@
video_frame_stream_->Initialize(
stream,
+ decoders,
statistics_cb,
base::Bind(&VideoRendererBase::OnVideoFrameStreamInitialized,
weak_this_));
« no previous file with comments | « trunk/src/media/filters/video_renderer_base.h ('k') | trunk/src/media/filters/video_renderer_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698