Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: trunk/src/media/filters/video_renderer_base_unittest.cc

Issue 14320005: Revert 194993 "Remove reference counting from media::VideoDecode..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/media/filters/video_renderer_base.cc ('k') | trunk/src/media/filters/vpx_video_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/media/filters/video_renderer_base_unittest.cc
===================================================================
--- trunk/src/media/filters/video_renderer_base_unittest.cc (revision 195011)
+++ trunk/src/media/filters/video_renderer_base_unittest.cc (working copy)
@@ -45,12 +45,8 @@
demuxer_stream_(new MockDemuxerStream()),
video_config_(kCodecVP8, VIDEO_CODEC_PROFILE_UNKNOWN, kVideoFormat,
kCodedSize, kVisibleRect, kNaturalSize, NULL, 0, false) {
- ScopedVector<VideoDecoder> decoders;
- decoders.push_back(decoder_);
-
renderer_.reset(new VideoRendererBase(
message_loop_.message_loop_proxy(),
- decoders.Pass(),
media::SetDecryptorReadyCB(),
base::Bind(&VideoRendererBaseTest::OnPaint, base::Unretained(this)),
base::Bind(&VideoRendererBaseTest::OnSetOpaque, base::Unretained(this)),
@@ -122,8 +118,11 @@
}
void CallInitialize(const PipelineStatusCB& status_cb) {
+ VideoRendererBase::VideoDecoderList decoders;
+ decoders.push_back(decoder_);
renderer_->Initialize(
demuxer_stream_,
+ decoders,
status_cb,
base::Bind(&MockStatisticsCB::OnStatistics,
base::Unretained(&statistics_cb_object_)),
@@ -296,7 +295,7 @@
protected:
// Fixture members.
scoped_ptr<VideoRendererBase> renderer_;
- MockVideoDecoder* decoder_; // Owned by |renderer_|.
+ scoped_refptr<MockVideoDecoder> decoder_;
scoped_refptr<MockDemuxerStream> demuxer_stream_;
MockStatisticsCB statistics_cb_object_;
« no previous file with comments | « trunk/src/media/filters/video_renderer_base.cc ('k') | trunk/src/media/filters/vpx_video_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698