Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1429953003: Belated code review regarding pexe content handler. (Closed)

Created:
5 years, 1 month ago by Sean Klein
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Belated code review regarding pexe content handler. Adds logging statement for translation process, and fixes incorrect comment regarding parent class of NaCl content handlers. See https://codereview.chromium.org/1382713002/ for original CL. BUG=#396 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5cdf1e75070e2bcb6f1d121cbc04628e658a7084

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M services/nacl/content_handler_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/content_handler_main_nonsfi.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/content_handler_main_nonsfi_pexe.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Sean Klein
5 years, 1 month ago (2015-11-03 14:31:28 UTC) #2
jamesr
Please put something more descriptive in the patch description (i.e. say what this patch does). ...
5 years, 1 month ago (2015-11-03 18:34:21 UTC) #3
Sean Klein
On 2015/11/03 18:34:21, jamesr wrote: > Please put something more descriptive in the patch description ...
5 years, 1 month ago (2015-11-03 18:42:09 UTC) #6
jamesr
lgtm Instead of BUG=https://../396 say just #396
5 years, 1 month ago (2015-11-03 18:46:22 UTC) #7
Sean Klein
5 years, 1 month ago (2015-11-03 18:48:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5cdf1e75070e2bcb6f1d121cbc04628e658a7084.

Powered by Google App Engine
This is Rietveld 408576698