Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc

Issue 1429953003: Belated code review regarding pexe content handler. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/nacl/content_handler_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc
diff --git a/mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc b/mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc
index a49fbda1705ebf747869a124fc1be38adde0a55b..844f2bf56ca55fd1abdad3d93e44f9ba77d14d3f 100644
--- a/mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc
+++ b/mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc
@@ -55,6 +55,9 @@ class PexeCompilerImpl : public mojo::nacl::PexeCompiler {
LOG(FATAL) << "Could not unlink temporary pexe file";
if (pexe_file_stream == nullptr)
LOG(FATAL) << "Could not open pexe for reading";
+ // TODO(smklein): Remove these LOG statements once translation speed
+ // is improved.
+ LOG(INFO) << "Starting compilation of pexe into nexe";
for (;;) {
size_t num_bytes_from_pexe = fread(buf.get(), 1, kBufferSize,
pexe_file_stream);
@@ -65,6 +68,7 @@ class PexeCompilerImpl : public mojo::nacl::PexeCompiler {
break;
}
funcs_->data_callback(buf.get(), num_bytes_from_pexe);
+ LOG(INFO) << "Compiled " << num_bytes_from_pexe << " bytes";
}
buf.reset();
« no previous file with comments | « no previous file | services/nacl/content_handler_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698