Belated code review regarding pexe content handler.

mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <fcntl.h>
 
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "mojo/nacl/nonsfi/irt_mojo_nonsfi.h"
 #include "mojo/public/cpp/bindings/string.h"
@@ skipping 37 matching lines @@
 
     // Read the pexe using fread, and write the pexe into the callback function.
     static const size_t kBufferSize = 0x100000;
     scoped_ptr<char[]> buf(new char[kBufferSize]);
     FILE* pexe_file_stream = fopen(pexe_file_name.get().c_str(), "r");
     // Once the pexe has been opened, it is no longer needed, so we unlink it.
     if (unlink(pexe_file_name.get().c_str()))
       LOG(FATAL) << "Could not unlink temporary pexe file";
     if (pexe_file_stream == nullptr)
       LOG(FATAL) << "Could not open pexe for reading";
+    // TODO(smklein): Remove these LOG statements once translation speed
+    // is improved.
+    LOG(INFO) << "Starting compilation of pexe into nexe";
     for (;;) {
       size_t num_bytes_from_pexe = fread(buf.get(), 1, kBufferSize,
                                          pexe_file_stream);
       if (ferror(pexe_file_stream)) {
         LOG(FATAL) << "Error reading from pexe file stream";
       }
       if (num_bytes_from_pexe == 0) {
         break;
       }
       funcs_->data_callback(buf.get(), num_bytes_from_pexe);
+      LOG(INFO) << "Compiled " << num_bytes_from_pexe << " bytes";
     }
     buf.reset();
 
     if (fclose(pexe_file_stream))
       LOG(FATAL) << "Failed to close pexe file stream from compiler nexe";
     funcs_->end_callback();
 
     // Return the name of the object file.
     callback.Run(mojo::String(obj_file_name.value()));
     mojo::RunLoop::current()->Quit();
@@ skipping 20 matching lines @@
 }  // namespace anonymous
 
 namespace nacl {
 
 const struct nacl_irt_private_pnacl_translator_compile
     nacl_irt_private_pnacl_translator_compile = {
   ServeTranslateRequest
 };
 
 }  // namespace nacl