services/nacl/content_handler_main_nonsfi.cc - Issue 1429953003: Belated code review regarding pexe content handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/nacl/content_handler_main_nonsfi.cc

Issue 1429953003: Belated code review regarding pexe content handler. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/nacl/content_handler_main_nonsfi.cc

diff --git a/services/nacl/content_handler_main_nonsfi.cc b/services/nacl/content_handler_main_nonsfi.cc

index 5eee6753e1869e8255ec5760f9dc5d0ae731ca44..86b0ad5bed6849b16e9b5d3835b594766310bfeb 100644

--- a/services/nacl/content_handler_main_nonsfi.cc

+++ b/services/nacl/content_handler_main_nonsfi.cc

@@ -32,7 +32,7 @@ class NaClContentHandler : public mojo::ApplicationDelegate,

return true;

}

- // Overridden from ContentHandlerFactory::ManagedDelegate:

+ // Overridden from ContentHandlerFactory::Delegate:

void RunApplication(

mojo::InterfaceRequest<mojo::Application> application_request,

mojo::URLResponsePtr response) override {