Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 14296002: Use classList#toggle instead of classList[whatever ? 'add' : 'remove']. (Closed)

Created:
7 years, 8 months ago by dconnelly
Modified:
7 years, 8 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use classList#toggle instead of classList[whatever ? 'add' : 'remove']. BUG=232048 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194583

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/resources/chromeos/login/bubble.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_account_picker.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_password_changed.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dconnelly
7 years, 8 months ago (2013-04-16 12:13:57 UTC) #1
Nikita (slow)
lgtm
7 years, 8 months ago (2013-04-16 13:22:41 UTC) #2
dconnelly
On 2013/04/16 13:22:41, Nikita Kostylev wrote: > lgtm Nikita, do you mind dcommit-ing this?
7 years, 8 months ago (2013-04-17 11:33:02 UTC) #3
Nikita (slow)
7 years, 8 months ago (2013-04-17 12:46:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r194583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698