chrome/browser/resources/chromeos/login/screen_error_message.js - Issue 14296002: Use classList#toggle instead of classList[whatever ? 'add' : 'remove'].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/screen_error_message.js

Issue 14296002: Use classList#toggle instead of classList[whatever ? 'add' : 'remove']. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/screen_account_picker.js ('k') | chrome/browser/resources/chromeos/login/screen_gaia_signin.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/screen_error_message.js

diff --git a/chrome/browser/resources/chromeos/login/screen_error_message.js b/chrome/browser/resources/chromeos/login/screen_error_message.js

index 8a1072933ff6e4e5f424fe00048b4b57f87830d3..180070aadcf51ccf940478927596df8139610649 100644

--- a/chrome/browser/resources/chromeos/login/screen_error_message.js

+++ b/chrome/browser/resources/chromeos/login/screen_error_message.js

@@ -196,7 +196,7 @@ cr.define('login', function() {

* @private

allowGuestSignin_: function(allowed) {

- this.classList[allowed ? 'add' : 'remove']('allow-guest-signin');

+ this.classList.toggle('allow-guest-signin', allowed);

this.onContentChange_();

@@ -205,7 +205,7 @@ cr.define('login', function() {

* @private

allowOfflineLogin_: function(allowed) {

- this.classList[allowed ? 'add' : 'remove']('allow-offline-login');

+ this.classList.toggle('allow-offline-login', allowed);

this.onContentChange_();

};