chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js - Issue 14296002: Use classList#toggle instead of classList[whatever ? 'add' : 'remove'].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js

Issue 14296002: Use classList#toggle instead of classList[whatever ? 'add' : 'remove']. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/screen_gaia_signin.js ('k') | chrome/browser/resources/chromeos/login/screen_password_changed.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js

diff --git a/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js b/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js

index 0981edcb2abad855c7cc24d3a5f6c4e1f38ed12f..2211dfdb84aaa05db5d23a23612b6b2d0a2c73eb 100644

--- a/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js

+++ b/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js

@@ -466,9 +466,9 @@ cr.define('login', function() {

set nameErrorVisible(value) {

$('managed-user-creation-flow-name-error').

- classList[value ? 'add' : 'remove']('error');

+ classList.toggle('error', value);

$('managed-user-creation-flow-name').

- classList[value ? 'add' : 'remove']('duplicate-name');

+ classList.toggle('duplicate-name', value);

if (!value)

$('managed-user-creation-flow-name-error').textContent = '';

@@ -479,7 +479,7 @@ cr.define('login', function() {

set passwordErrorVisible(value) {

$('managed-user-creation-flow-password-error').

- classList[value ? 'add' : 'remove']('error');

+ classList.toggle('error', value);

if (!value)

$('managed-user-creation-flow-password-error').textContent = '';