chrome/browser/resources/chromeos/login/bubble.js - Issue 14296002: Use classList#toggle instead of classList[whatever ? 'add' : 'remove'].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/bubble.js

Issue 14296002: Use classList#toggle instead of classList[whatever ? 'add' : 'remove']. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/login/bubble.js

diff --git a/chrome/browser/resources/chromeos/login/bubble.js b/chrome/browser/resources/chromeos/login/bubble.js

index 411ad8c406f528867d3b1f7cd42a069cc56b72db..89a20f864aa1ff09bb7b539953ddc1d354f92fbe 100644

--- a/chrome/browser/resources/chromeos/login/bubble.js

+++ b/chrome/browser/resources/chromeos/login/bubble.js

@@ -99,7 +99,7 @@ cr.define('cr.ui', function() {

setAttachment_: function(attachment) {

for (var k in Bubble.Attachment) {

var v = Bubble.Attachment[k];

- this.classList[v == attachment ? 'add' : 'remove'](v);

+ this.classList.toggle(v, v == attachment);

}

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/login/screen_account_picker.js » ('j') | no next file with comments »