Reland v8::Private and related APIs

Reland v8::Private and related APIs

Also deprecate hidden values

BUG=none
LOG=y
R=rossberg@chromium.org,yangguo@chromium.org

Committed: https://crrev.com/e04d313d9f1e61c3a3145d962143c9867f23326d
Cr-Commit-Position: refs/heads/master@{#31658}

[jochen (gone - plz use gerrit), 2015-10-29 13:41:14]

ptal

I changed the API to not depend on the deprecated ForceSet apis

also, I'm only checking the object for Has/Get, so the symbols are no longer
inherited.

[rossberg, 2015-10-29 14:06:16]

LGTM

https://codereview.chromium.org/1428793002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1428793002/diff/20001/include/v8.h#newcode2751
include/v8.h:2751: Maybe<bool> DeletePrivate(Local<Context> context,
Local<Private> key);
As discussed offline, if there is no real use case for deleting hidden
properties then I'd suggest not providing this function -- private properties
are primarily meant to model [[internal]] properties, and these are usually
persistent.

[jochen (gone - plz use gerrit), 2015-10-29 14:14:21]

On 2015/10/29 at 14:06:16, rossberg wrote:
> LGTM
> 
> https://codereview.chromium.org/1428793002/diff/20001/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/1428793002/diff/20001/include/v8.h#newcode2751
> include/v8.h:2751: Maybe<bool> DeletePrivate(Local<Context> context,
Local<Private> key);
> As discussed offline, if there is no real use case for deleting hidden
properties then I'd suggest not providing this function -- private properties
are primarily meant to model [[internal]] properties, and these are usually
persistent.

both blink and chrome make use of this, so I guess we have to expose this.

[Yang, 2015-10-29 14:15:02]

On 2015/10/29 14:06:16, rossberg wrote:
> LGTM
> 
> https://codereview.chromium.org/1428793002/diff/20001/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/1428793002/diff/20001/include/v8.h#newcode2751
> include/v8.h:2751: Maybe<bool> DeletePrivate(Local<Context> context,
> Local<Private> key);
> As discussed offline, if there is no real use case for deleting hidden
> properties then I'd suggest not providing this function -- private properties
> are primarily meant to model [[internal]] properties, and these are usually
> persistent.

lgtm.

[jochen (gone - plz use gerrit), 2015-10-29 14:15:51]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-10-29 14:15:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428793002/20001

[commit-bot: I haz the power, 2015-10-29 14:17:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-29 14:17:42]

Patchset 2 (id:??) landed as
https://crrev.com/e04d313d9f1e61c3a3145d962143c9867f23326d
Cr-Commit-Position: refs/heads/master@{#31658}