Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 1428793002: Reland v8::Private and related APIs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index be074f8ba8162ea80ba19c84beed2124f013114f..932e861a2f4d1640d4e06671f730f272e696b507 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -1983,21 +1983,24 @@ TEST(HiddenPropertiesFastCase) {
GetProperty(global, v8::HeapGraphEdge::kProperty, "c");
CHECK(c);
const v8::HeapGraphNode* hidden_props =
- GetProperty(c, v8::HeapGraphEdge::kInternal, "hidden_properties");
+ GetProperty(c, v8::HeapGraphEdge::kProperty, "<symbol>");
CHECK(!hidden_props);
v8::Handle<v8::Value> cHandle =
env->Global()->Get(v8::String::NewFromUtf8(env->GetIsolate(), "c"));
CHECK(!cHandle.IsEmpty() && cHandle->IsObject());
- cHandle->ToObject(isolate)->SetHiddenValue(v8_str("key"), v8_str("val"));
+ cHandle->ToObject(isolate)
+ ->SetPrivate(env.local(),
+ v8::Private::ForApi(env->GetIsolate(), v8_str("key")),
+ v8_str("val"))
+ .FromJust();
snapshot = heap_profiler->TakeHeapSnapshot();
CHECK(ValidateSnapshot(snapshot));
global = GetGlobalObject(snapshot);
c = GetProperty(global, v8::HeapGraphEdge::kProperty, "c");
CHECK(c);
- hidden_props = GetProperty(c, v8::HeapGraphEdge::kInternal,
- "hidden_properties");
+ hidden_props = GetProperty(c, v8::HeapGraphEdge::kProperty, "<symbol>");
CHECK(hidden_props);
}

Powered by Google App Engine
This is Rietveld 408576698