Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: test/cctest/test-dictionary.cc

Issue 1428793002: Reland v8::Private and related APIs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-dictionary.cc
diff --git a/test/cctest/test-dictionary.cc b/test/cctest/test-dictionary.cc
index b7320948158ee36e96bd1afe18de697b60a5e962..68c35f958efd09a3c51a18acf3d0c39e69cb1e54 100644
--- a/test/cctest/test-dictionary.cc
+++ b/test/cctest/test-dictionary.cc
@@ -171,12 +171,6 @@ static void TestHashSetCausesGC(Handle<HashSet> table) {
Factory* factory = isolate->factory();
Handle<JSObject> key = factory->NewJSArray(0);
- v8::Handle<v8::Object> key_obj = v8::Utils::ToLocal(key);
-
- // Force allocation of hash table backing store for hidden properties.
- key_obj->SetHiddenValue(v8_str("key 1"), v8_str("val 1"));
- key_obj->SetHiddenValue(v8_str("key 2"), v8_str("val 2"));
- key_obj->SetHiddenValue(v8_str("key 3"), v8_str("val 3"));
// Simulate a full heap so that generating an identity hash code
// in subsequent calls will request GC.
@@ -208,12 +202,6 @@ static void TestHashMapCausesGC(Handle<HashMap> table) {
Factory* factory = isolate->factory();
Handle<JSObject> key = factory->NewJSArray(0);
- v8::Handle<v8::Object> key_obj = v8::Utils::ToLocal(key);
-
- // Force allocation of hash table backing store for hidden properties.
- key_obj->SetHiddenValue(v8_str("key 1"), v8_str("val 1"));
- key_obj->SetHiddenValue(v8_str("key 2"), v8_str("val 2"));
- key_obj->SetHiddenValue(v8_str("key 3"), v8_str("val 3"));
// Simulate a full heap so that generating an identity hash code
// in subsequent calls will request GC.
« include/v8.h ('K') | « test/cctest/test-debug.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698