Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: test/cctest/test-object-observe.cc

Issue 1428793002: Reland v8::Private and related APIs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/v8.h ('K') | « test/cctest/test-heap-profiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-object-observe.cc
diff --git a/test/cctest/test-object-observe.cc b/test/cctest/test-object-observe.cc
index 81edf3f40feee4dc69a5e07f0bc8ca8fb5468e3d..64d71cc5e066c18cf9e73b7517d1a60cb1ceb97f 100644
--- a/test/cctest/test-object-observe.cc
+++ b/test/cctest/test-object-observe.cc
@@ -687,7 +687,10 @@ TEST(HiddenPropertiesLeakage) {
->Get(v8::Isolate::GetCurrent()->GetCurrentContext(), v8_str("obj"))
.ToLocalChecked();
Local<Object>::Cast(obj)
- ->SetHiddenValue(v8_str("foo"), Null(CcTest::isolate()));
+ ->SetPrivate(v8::Isolate::GetCurrent()->GetCurrentContext(),
+ v8::Private::New(CcTest::isolate(), v8_str("foo")),
+ Null(CcTest::isolate()))
+ .FromJust();
CompileRun(""); // trigger delivery
CHECK(CompileRun("records")->IsNull());
}
« include/v8.h ('K') | « test/cctest/test-heap-profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698