Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1427663004: Use BitmapHttpRequest to fetch favicon for Nearby URLs (Closed)

Created:
5 years, 1 month ago by mattreynolds
Modified:
5 years, 1 month ago
Reviewers:
dvh, gone, cco3
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[physicalweb] Use BitmapHttpRequest to fetch favicon for Nearby URLs Cache icon bitmaps in NearbyUrlsAdapter. Fix a bug in HttpRequest that incorrectly set doOutput to true for requests that do not need to send additional data. BUG=529962 Committed: https://crrev.com/82c2d901e90b6d8afaa74c43df8b2e66054a2df7 Cr-Commit-Position: refs/heads/master@{#356724}

Patch Set 1 #

Total comments: 3

Patch Set 2 : wip (taking changes from dfalcantara,dvh) #

Messages

Total messages: 16 (5 generated)
mattreynolds
Hi dfalcantara, could you please take a look at //chrome/android/java? Thanks!
5 years, 1 month ago (2015-10-28 23:23:07 UTC) #4
cco3
lgtm
5 years, 1 month ago (2015-10-28 23:31:26 UTC) #5
gone
lgtm Are you missing some files? Your comment said to look at files under //chrome/android/java, ...
5 years, 1 month ago (2015-10-28 23:41:35 UTC) #6
dvh
https://codereview.chromium.org/1427663004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (right): https://codereview.chromium.org/1427663004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java#newcode104 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:104: AsyncTask.THREAD_POOL_EXECUTOR.execute(iconRequest); I would rather move the threading logic to ...
5 years, 1 month ago (2015-10-28 23:46:40 UTC) #7
mattreynolds
> Are you missing some files? Your comment said to look at files under > ...
5 years, 1 month ago (2015-10-29 00:34:44 UTC) #8
cco3
https://codereview.chromium.org/1427663004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (right): https://codereview.chromium.org/1427663004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java#newcode104 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:104: AsyncTask.THREAD_POOL_EXECUTOR.execute(iconRequest); On 2015/10/28 23:46:40, dvh wrote: > I would ...
5 years, 1 month ago (2015-10-29 00:38:13 UTC) #9
cco3
lgtm
5 years, 1 month ago (2015-10-29 00:38:39 UTC) #10
dvh
lgtm
5 years, 1 month ago (2015-10-29 00:39:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427663004/20001
5 years, 1 month ago (2015-10-29 00:43:19 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 01:23:53 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 01:24:39 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82c2d901e90b6d8afaa74c43df8b2e66054a2df7
Cr-Commit-Position: refs/heads/master@{#356724}

Powered by Google App Engine
This is Rietveld 408576698