Use BitmapHttpRequest to fetch favicon for Nearby URLs

chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.physicalweb;
 
 import android.app.ListActivity;
 import android.content.Intent;
+import android.graphics.Bitmap;
 import android.net.Uri;
+import android.os.AsyncTask;
 import android.os.Bundle;
 import android.view.View;
-import android.widget.ArrayAdapter;
 import android.widget.ListView;
 
+import org.chromium.base.Log;
 import org.chromium.chrome.R;
 
+import java.net.MalformedURLException;
 import java.util.Collection;
 import java.util.HashSet;
 
 /**
  * This activity displays a list of nearby URLs as stored in the {@link UrlManager}.
  * This activity does not and should not rely directly or indirectly on the native library.
  */
 public class ListUrlsActivity extends ListActivity {
     private static final String TAG = "PhysicalWeb";
-    private ArrayAdapter<PwsResult> mAdapter;
+    private NearbyUrlsAdapter mAdapter;
     private PwsClient mPwsClient;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.physical_web_list_urls_activity);
 
         mAdapter = new NearbyUrlsAdapter(this);
         setListAdapter(mAdapter);
 
         mPwsClient = new PwsClient();
     }
 
     @Override
     protected void onResume() {
         super.onResume();
         mAdapter.clear();
         Collection<String> urls = UrlManager.getInstance(this).getUrls();
         mPwsClient.resolve(urls, new PwsClient.ResolveScanCallback() {
             @Override
             public void onPwsResults(Collection<PwsResult> pwsResults) {
                 // filter out duplicate site URLs
                 Collection<String> siteUrls = new HashSet<>();
                 for (PwsResult pwsResult : pwsResults) {
                     String siteUrl = pwsResult.siteUrl;
+                    String iconUrl = pwsResult.iconUrl;
+
                     if (siteUrl != null && !siteUrls.contains(siteUrl)) {
                         siteUrls.add(siteUrl);
                         mAdapter.add(pwsResult);
+
+                        if (iconUrl != null) {
+                            fetchIcon(iconUrl);
+                        }
                     }
                 }
             }
         });
     }
 
     /**
      * Handle a click event.
      * @param l The ListView.
      * @param v The View that was clicked inside the ListView.
      * @param position The position of the clicked element in the list.
      * @param id The row id of the clicked element in the list.
      */
     @Override
     public void onListItemClick(ListView l, View v, int position, long id) {
         PwsResult pwsResult = mAdapter.getItem(position);
         Intent intent = createNavigateToUrlIntent(pwsResult);
         startActivity(intent);
     }
 
+    private void fetchIcon(final String iconUrl) {
+        BitmapHttpRequest iconRequest = null;
+        try {
+            iconRequest = new BitmapHttpRequest(iconUrl, new BitmapHttpRequest.RequestCallback() {
+                @Override
+                public void onResponse(Bitmap iconBitmap) {
+                    mAdapter.setIcon(iconUrl, iconBitmap);
+                }
+
+                @Override
+                public void onError(int httpResponseCode, Exception e) {
+                    Log.e(TAG, "Error fetching icon, returned code " + httpResponseCode);
+                }
+            });
+        } catch (MalformedURLException e) {
+            Log.e(TAG, "Error creating icon request, malformed icon URL");
+        }
+
+        if (iconRequest != null) {
+            // The callback will be called on the main thread.
+            AsyncTask.THREAD_POOL_EXECUTOR.execute(iconRequest);

[dvh, 2015/10/28 23:46:40]

I would rather move the threading logic to PwsClient.

[cco3, 2015/10/29 00:38:13]

Yea, this whole method could be moved to PwsClient...you could pass in a
PwsResult instead of an iconUrl if you want to make it more clearly associated
with the PwsClient.

+        }
+    }
+
     private static Intent createNavigateToUrlIntent(PwsResult pwsResult) {
         String url = pwsResult.siteUrl;
         if (url == null) {
             url = pwsResult.requestUrl;
         }
 
         Intent intent = new Intent(Intent.ACTION_VIEW);
         intent.addCategory(Intent.CATEGORY_BROWSABLE);
         intent.setData(Uri.parse(url));
         return intent;
     }
 }