chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java - Issue 1427663004: Use BitmapHttpRequest to fetch favicon for Nearby URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java

Issue 1427663004: Use BitmapHttpRequest to fetch favicon for Nearby URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip (taking changes from dfalcantara,dvh) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/HttpRequest.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java

index ffc17241765c9b4e92d6529d4cfc8a60c175f15b..c8c68035fc2e3a1c2d217524a4155885c6b2c3e5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/JsonObjectHttpRequest.java

@@ -43,6 +43,7 @@ class JsonObjectHttpRequest extends HttpRequest<JSONObject> {

* @param urlConnection The HTTP connection.

public void writeToUrlConnection(HttpURLConnection urlConnection) throws IOException {

+ urlConnection.setDoOutput(true);

urlConnection.setRequestProperty("Content-Type", "application/json");

urlConnection.setRequestProperty("Accept", "application/json");

urlConnection.setRequestMethod("POST");