Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java

Issue 1427663004: Use BitmapHttpRequest to fetch favicon for Nearby URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wip (taking changes from dfalcantara,dvh) Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
index 979beddb612074610b5ff62e86cbc00270142199..56004e657c30a3f3cd49a2c8ef3eb46354f22bff 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
@@ -6,10 +6,10 @@ package org.chromium.chrome.browser.physicalweb;
import android.app.ListActivity;
import android.content.Intent;
+import android.graphics.Bitmap;
import android.net.Uri;
import android.os.Bundle;
import android.view.View;
-import android.widget.ArrayAdapter;
import android.widget.ListView;
import org.chromium.chrome.R;
@@ -23,7 +23,7 @@ import java.util.HashSet;
*/
public class ListUrlsActivity extends ListActivity {
private static final String TAG = "PhysicalWeb";
- private ArrayAdapter<PwsResult> mAdapter;
+ private NearbyUrlsAdapter mAdapter;
private PwsClient mPwsClient;
@Override
@@ -49,9 +49,15 @@ public class ListUrlsActivity extends ListActivity {
Collection<String> siteUrls = new HashSet<>();
for (PwsResult pwsResult : pwsResults) {
String siteUrl = pwsResult.siteUrl;
+ String iconUrl = pwsResult.iconUrl;
+
if (siteUrl != null && !siteUrls.contains(siteUrl)) {
siteUrls.add(siteUrl);
mAdapter.add(pwsResult);
+
+ if (iconUrl != null) {
+ fetchIcon(iconUrl);
+ }
}
}
}
@@ -72,6 +78,15 @@ public class ListUrlsActivity extends ListActivity {
startActivity(intent);
}
+ private void fetchIcon(String iconUrl) {
+ mPwsClient.fetchIcon(iconUrl, new PwsClient.FetchIconCallback() {
+ @Override
+ public void onIconReceived(String url, Bitmap bitmap) {
+ mAdapter.setIcon(url, bitmap);
+ }
+ });
+ }
+
private static Intent createNavigateToUrlIntent(PwsResult pwsResult) {
String url = pwsResult.siteUrl;
if (url == null) {

Powered by Google App Engine
This is Rietveld 408576698