Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1427633010: Fix relative includes within core/ (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : IWYU #

Total comments: 16

Patch Set 3 : nits #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -365 lines) Patch
M core/src/fdrm/crypto/fx_crypt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fdrm/crypto/fx_crypt_aes.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fdrm/crypto/fx_crypt_sha.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_basic_module.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/cmaps_gb1.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/cmaps_gb1.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/cmaps_japan1.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/cmaps_japan1.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/cmaps_korea1.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/cmaps_korea1.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/cmap_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/editint.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/common.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 2 3 1 chunk +7 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_path.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/parser_int.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_metadata.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_ocg.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_viewerPreferences.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_vtmodule.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/tagged_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/text_int.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/unicodenormalization.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/unicodenormalizationdata.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/unicodenormalizationdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jbig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_BitStream.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_BitStream.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Define.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrdProc.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrdProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrrdProc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GsidProc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GsidProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HtrdProc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HtrdProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Image.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_List.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Page.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_PatternDict.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_PddProc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SddProc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SddProc.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Segment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_TrdProc.h View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fxcrt/extension.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_array.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_coords.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_gcc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_list.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_maps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_memmgr.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_memmgr_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_plex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_utf.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_util.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_bidi.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_bidi_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_system_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_ucddata.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_unicode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_xml_composer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_platforms.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_posix.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_windows.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcrt/plex.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcrt/xml_int.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 1 2 chunks +7 lines, -3 lines 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fxge/android/fpf_skiafont.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiamodule.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fx_fpf.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/apple/apple_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M core/src/fxge/apple/fx_mac_imp.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M core/src/fxge/dib/dib_int.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxge/freetype/fx_freetype.c View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_device.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_ps.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fxge/ge/text_int.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxge/skia/fx_skia_blitter_new.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 1 2 2 chunks +12 lines, -14 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dib.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 1 chunk +9 lines, -5 lines 0 comments Download
M core/src/fxge/win32/win32_int.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Lei Zhang
5 years, 1 month ago (2015-11-07 00:58:48 UTC) #2
Tom Sepez
https://codereview.chromium.org/1427633010/diff/20001/core/src/fpdfapi/fpdf_font/common.h File core/src/fpdfapi/fpdf_font/common.h (right): https://codereview.chromium.org/1427633010/diff/20001/core/src/fpdfapi/fpdf_font/common.h#newcode12 core/src/fpdfapi/fpdf_font/common.h:12: typedef signed char TT_int8_t; nit: someday use stdint types ...
5 years, 1 month ago (2015-11-09 21:46:17 UTC) #3
Lei Zhang
https://codereview.chromium.org/1427633010/diff/20001/core/src/fpdfapi/fpdf_font/common.h File core/src/fpdfapi/fpdf_font/common.h (right): https://codereview.chromium.org/1427633010/diff/20001/core/src/fpdfapi/fpdf_font/common.h#newcode12 core/src/fpdfapi/fpdf_font/common.h:12: typedef signed char TT_int8_t; On 2015/11/09 21:46:16, Tom Sepez ...
5 years, 1 month ago (2015-11-10 09:27:56 UTC) #4
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-10 17:04:57 UTC) #5
Lei Zhang
5 years, 1 month ago (2015-11-10 17:41:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
9fb27cb9797937499c9678bc74cf7846cbf5d2b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698