Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1437603002: Remove core/src/fpdfapi/fpdf_font/common.h and use stdint types. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove core/src/fpdfapi/fpdf_font/common.h and use stdint types. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/21e079dd982f57daa9d5af0d9e48d58189ce35da

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -115 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D core/src/fpdfapi/fpdf_font/common.h View 1 1 chunk +0 lines, -21 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.h View 1 22 chunks +61 lines, -60 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 17 chunks +30 lines, -30 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
5 years, 1 month ago (2015-11-10 09:17:52 UTC) #2
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-10 17:01:58 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-10 17:58:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
21e079dd982f57daa9d5af0d9e48d58189ce35da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698