Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1425723003: Provide fallback for scrollingElement in telemetry tests. (Closed)

Created:
5 years, 1 month ago by Rick Byers
Modified:
5 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide fallback for scrollingElement in telemetry tests. document.scrollingElement was added in M44, but apparently the ref build is currently older than that. Provide a temporary fallback without loosing the benefit of https://codereview.chromium.org/1428733002. CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect BUG=549644 Committed: https://crrev.com/c54fdd338ab1eaf2995439162beb25e9f8f3bf7a Cr-Commit-Position: refs/heads/master@{#357152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/telemetry/telemetry/internal/actions/action_runner_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/actions/scroll.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/actions/scroll.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/actions/scroll_bounce.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/actions/swipe.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Rick Byers
Sami, looks like we guessed wrong in https://codereview.chromium.org/1428733002#msg8. Kari says the ref build will be ...
5 years, 1 month ago (2015-10-30 16:38:21 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425723003/1
5 years, 1 month ago (2015-10-30 16:39:28 UTC) #6
aiolos (Not reviewing)
perf sheriff lgtm :)
5 years, 1 month ago (2015-10-30 16:39:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425723003/1
5 years, 1 month ago (2015-10-30 16:46:59 UTC) #10
Sami
lgtm, thanks for the quick fix -- and sorry for giving bad information in the ...
5 years, 1 month ago (2015-10-30 16:51:44 UTC) #11
Rick Byers
On 2015/10/30 16:51:44, Sami wrote: > lgtm, thanks for the quick fix -- and sorry ...
5 years, 1 month ago (2015-10-30 16:56:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 18:45:46 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 18:46:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c54fdd338ab1eaf2995439162beb25e9f8f3bf7a
Cr-Commit-Position: refs/heads/master@{#357152}

Powered by Google App Engine
This is Rietveld 408576698