tools/telemetry/telemetry/internal/actions/scroll.js - Issue 1425723003: Provide fallback for scrollingElement in telemetry tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/actions/scroll.js

Issue 1425723003: Provide fallback for scrollingElement in telemetry tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/actions/action_runner_unittest.py ('k') | tools/telemetry/telemetry/internal/actions/scroll.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/actions/scroll.js

diff --git a/tools/telemetry/telemetry/internal/actions/scroll.js b/tools/telemetry/telemetry/internal/actions/scroll.js

index ba809605f50fe11c17ac6abf8f7f8307a1f2d619..1e903de47f1e2e895140edf987891c13227fa4a5 100644

--- a/tools/telemetry/telemetry/internal/actions/scroll.js

+++ b/tools/telemetry/telemetry/internal/actions/scroll.js

@@ -20,7 +20,7 @@

this.speed_ = opt_options.speed;

this.gesture_source_type_ = opt_options.gesture_source_type;

} else {

- this.element_ = document.scrollingElement;

+ this.element_ = document.scrollingElement || document.body;

this.left_start_ratio_ = 0.5;

this.top_start_ratio_ = 0.5;

this.direction_ = 'down';