tools/telemetry/telemetry/internal/actions/scroll.py - Issue 1425723003: Provide fallback for scrollingElement in telemetry tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/actions/scroll.py

Issue 1425723003: Provide fallback for scrollingElement in telemetry tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/actions/scroll.js ('k') | tools/telemetry/telemetry/internal/actions/scroll_bounce.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/actions/scroll.py

diff --git a/tools/telemetry/telemetry/internal/actions/scroll.py b/tools/telemetry/telemetry/internal/actions/scroll.py

index f0a6c1b9a6e8191172dc86354c0f44d3bfded3cf..0cd53ef2ece6125db24cdb3d3ec1a85bddfb801b 100644

--- a/tools/telemetry/telemetry/internal/actions/scroll.py

+++ b/tools/telemetry/telemetry/internal/actions/scroll.py

@@ -78,7 +78,7 @@ class ScrollAction(page_action.PageAction):

def RunAction(self, tab):

if (self._selector is None and self._text is None and

self._element_function is None):

- self._element_function = 'document.scrollingElement'

+ self._element_function = '(document.scrollingElement || document.body)'

gesture_source_type = self._synthetic_gesture_source

if self._use_touch: