Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1428733002: Update telemetry tests to be agnostic to ScrollTopLeftInterop mode (Closed)

Created:
5 years, 1 month ago by Rick Byers
Modified:
5 years, 1 month ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update telemetry tests to be agnostic to ScrollTopLeftInterop mode See https://dev.opera.com/articles/fixing-the-scrolltop-bug/ for details of the issue. It should be possible to run telemetry with --enable-experimental-web-platform-features. BUG=157855 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/a9b90544c07f7e54781c91856d0019e1f3a1567a Cr-Commit-Position: refs/heads/master@{#356947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/telemetry/telemetry/internal/actions/action_runner_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/actions/scroll.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/actions/scroll.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/actions/scroll_bounce.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/actions/swipe.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Rick Byers
Sami, PTAL I had a developer reach out to me and mention that telemetry unit ...
5 years, 1 month ago (2015-10-29 02:25:48 UTC) #3
Sami
lgtm, thanks for the fix. I guess document.scrollingElement has been shipped for a while now ...
5 years, 1 month ago (2015-10-29 10:12:43 UTC) #4
Rick Byers
On 2015/10/29 10:12:43, Sami wrote: > lgtm, thanks for the fix. > > I guess ...
5 years, 1 month ago (2015-10-29 14:27:43 UTC) #5
Sami
On 2015/10/29 14:27:43, Rick Byers wrote: > On 2015/10/29 10:12:43, Sami wrote: > > lgtm, ...
5 years, 1 month ago (2015-10-29 19:04:13 UTC) #6
Rick Byers
On 2015/10/29 19:04:13, Sami wrote: > On 2015/10/29 14:27:43, Rick Byers wrote: > > On ...
5 years, 1 month ago (2015-10-29 20:01:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428733002/1
5 years, 1 month ago (2015-10-29 20:02:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 21:11:09 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 21:11:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9b90544c07f7e54781c91856d0019e1f3a1567a
Cr-Commit-Position: refs/heads/master@{#356947}

Powered by Google App Engine
This is Rietveld 408576698