Remove JSBuiltinsObject.

Remove JSBuiltinsObject.

R=verwaest@chromium.org

Committed: https://crrev.com/395bd6d70a63f16b214eec43c57dfbdd56f16929
Cr-Commit-Position: refs/heads/master@{#31711}

[Yang, 2015-10-27 14:02:17]

yangguo@chromium.org changed reviewers:
+ hpayer@chromium.org

[Yang, 2015-10-27 14:02:18]

Hannes, could you take a look at the heap changes? Thanks.

Toon, I'm not too sure about how to replace the JSBuiltinsObject that acts as
global object for the context in which the builtins code is run. I ended up with
a dummy JSGlobalObject, for which I added a bunch of exceptions to make
assertions work (these filtered out JSBuiltinsObjects).

Or should I keep JSBuiltinsObject but slim it down?

[Hannes Payer (out of office), 2015-10-28 14:32:34]

heap LGTM

[Yang, 2015-10-29 12:58:15]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 12:58:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703005/1

[commit-bot: I haz the power, 2015-10-29 13:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 13:30:57]

Dry run: This issue passed the CQ dry run.

[Yang, 2015-10-30 08:22:49]

On 2015/10/29 13:30:57, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

ping

[Toon Verwaest, 2015-11-02 10:08:48]

https://codereview.chromium.org/1424703005/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1424703005/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:2309:
Handle<JSGlobalObject>::cast(factory()->NewGlobalObject(global_fun));
Ugh. I guess it breaks all over the place if there's no global object here?

https://codereview.chromium.org/1424703005/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1424703005/diff/1/src/objects.h#newcode66
src/objects.h:66: //           - JSGlobalObject
I guess we don't need the distinction between GlobalObject and JSGlobalObject
anymore now.

[Yang, 2015-11-02 10:47:38]

https://codereview.chromium.org/1424703005/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1424703005/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:2309:
Handle<JSGlobalObject>::cast(factory()->NewGlobalObject(global_fun));
On 2015/11/02 10:08:48, Toon Verwaest wrote:
> Ugh. I guess it breaks all over the place if there's no global object here?

Yes... even though we do not access it, we expect one to be there in a bunch of
places.

https://codereview.chromium.org/1424703005/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1424703005/diff/1/src/objects.h#newcode66
src/objects.h:66: //           - JSGlobalObject
On 2015/11/02 10:08:48, Toon Verwaest wrote:
> I guess we don't need the distinction between GlobalObject and JSGlobalObject
> anymore now.

Yup. I'd like to remove the distinction in a separate CL.

[Toon Verwaest, 2015-11-02 11:02:58]

Ok. lgtm in that case.

[Yang, 2015-11-02 12:45:09]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-11-02 12:45:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424703005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424703005/1

[commit-bot: I haz the power, 2015-11-02 13:04:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-02 13:04:47]

Patchset 1 (id:??) landed as
https://crrev.com/395bd6d70a63f16b214eec43c57dfbdd56f16929
Cr-Commit-Position: refs/heads/master@{#31711}