Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: src/objects-inl.h

Issue 1424703005: Remove JSBuiltinsObject. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 999 matching lines...) Expand 10 before | Expand all | Expand 10 after
1010 } 1010 }
1011 1011
1012 1012
1013 bool Object::IsGlobalObject() const { 1013 bool Object::IsGlobalObject() const {
1014 if (!IsHeapObject()) return false; 1014 if (!IsHeapObject()) return false;
1015 return HeapObject::cast(this)->map()->IsGlobalObjectMap(); 1015 return HeapObject::cast(this)->map()->IsGlobalObjectMap();
1016 } 1016 }
1017 1017
1018 1018
1019 TYPE_CHECKER(JSGlobalObject, JS_GLOBAL_OBJECT_TYPE) 1019 TYPE_CHECKER(JSGlobalObject, JS_GLOBAL_OBJECT_TYPE)
1020 TYPE_CHECKER(JSBuiltinsObject, JS_BUILTINS_OBJECT_TYPE)
1021 1020
1022 1021
1023 bool Object::IsUndetectableObject() const { 1022 bool Object::IsUndetectableObject() const {
1024 return IsHeapObject() 1023 return IsHeapObject()
1025 && HeapObject::cast(this)->map()->is_undetectable(); 1024 && HeapObject::cast(this)->map()->is_undetectable();
1026 } 1025 }
1027 1026
1028 1027
1029 bool Object::IsAccessCheckNeeded() const { 1028 bool Object::IsAccessCheckNeeded() const {
1030 if (!IsHeapObject()) return false; 1029 if (!IsHeapObject()) return false;
(...skipping 1109 matching lines...) Expand 10 before | Expand all | Expand 10 after
2140 if (type == JS_OBJECT_TYPE) return JSObject::kHeaderSize; 2139 if (type == JS_OBJECT_TYPE) return JSObject::kHeaderSize;
2141 switch (type) { 2140 switch (type) {
2142 case JS_GENERATOR_OBJECT_TYPE: 2141 case JS_GENERATOR_OBJECT_TYPE:
2143 return JSGeneratorObject::kSize; 2142 return JSGeneratorObject::kSize;
2144 case JS_MODULE_TYPE: 2143 case JS_MODULE_TYPE:
2145 return JSModule::kSize; 2144 return JSModule::kSize;
2146 case JS_GLOBAL_PROXY_TYPE: 2145 case JS_GLOBAL_PROXY_TYPE:
2147 return JSGlobalProxy::kSize; 2146 return JSGlobalProxy::kSize;
2148 case JS_GLOBAL_OBJECT_TYPE: 2147 case JS_GLOBAL_OBJECT_TYPE:
2149 return JSGlobalObject::kSize; 2148 return JSGlobalObject::kSize;
2150 case JS_BUILTINS_OBJECT_TYPE:
2151 return JSBuiltinsObject::kSize;
2152 case JS_FUNCTION_TYPE: 2149 case JS_FUNCTION_TYPE:
2153 return JSFunction::kSize; 2150 return JSFunction::kSize;
2154 case JS_VALUE_TYPE: 2151 case JS_VALUE_TYPE:
2155 return JSValue::kSize; 2152 return JSValue::kSize;
2156 case JS_DATE_TYPE: 2153 case JS_DATE_TYPE:
2157 return JSDate::kSize; 2154 return JSDate::kSize;
2158 case JS_ARRAY_TYPE: 2155 case JS_ARRAY_TYPE:
2159 return JSArray::kSize; 2156 return JSArray::kSize;
2160 case JS_ARRAY_BUFFER_TYPE: 2157 case JS_ARRAY_BUFFER_TYPE:
2161 return JSArrayBuffer::kSize; 2158 return JSArrayBuffer::kSize;
(...skipping 1145 matching lines...) Expand 10 before | Expand all | Expand 10 after
3307 CAST_ACCESSOR(GlobalDictionary) 3304 CAST_ACCESSOR(GlobalDictionary)
3308 CAST_ACCESSOR(GlobalObject) 3305 CAST_ACCESSOR(GlobalObject)
3309 CAST_ACCESSOR(HandlerTable) 3306 CAST_ACCESSOR(HandlerTable)
3310 CAST_ACCESSOR(HeapObject) 3307 CAST_ACCESSOR(HeapObject)
3311 CAST_ACCESSOR(Int16x8) 3308 CAST_ACCESSOR(Int16x8)
3312 CAST_ACCESSOR(Int32x4) 3309 CAST_ACCESSOR(Int32x4)
3313 CAST_ACCESSOR(Int8x16) 3310 CAST_ACCESSOR(Int8x16)
3314 CAST_ACCESSOR(JSArray) 3311 CAST_ACCESSOR(JSArray)
3315 CAST_ACCESSOR(JSArrayBuffer) 3312 CAST_ACCESSOR(JSArrayBuffer)
3316 CAST_ACCESSOR(JSArrayBufferView) 3313 CAST_ACCESSOR(JSArrayBufferView)
3317 CAST_ACCESSOR(JSBuiltinsObject)
3318 CAST_ACCESSOR(JSDataView) 3314 CAST_ACCESSOR(JSDataView)
3319 CAST_ACCESSOR(JSDate) 3315 CAST_ACCESSOR(JSDate)
3320 CAST_ACCESSOR(JSFunction) 3316 CAST_ACCESSOR(JSFunction)
3321 CAST_ACCESSOR(JSFunctionProxy) 3317 CAST_ACCESSOR(JSFunctionProxy)
3322 CAST_ACCESSOR(JSGeneratorObject) 3318 CAST_ACCESSOR(JSGeneratorObject)
3323 CAST_ACCESSOR(JSGlobalObject) 3319 CAST_ACCESSOR(JSGlobalObject)
3324 CAST_ACCESSOR(JSGlobalProxy) 3320 CAST_ACCESSOR(JSGlobalProxy)
3325 CAST_ACCESSOR(JSMap) 3321 CAST_ACCESSOR(JSMap)
3326 CAST_ACCESSOR(JSMapIterator) 3322 CAST_ACCESSOR(JSMapIterator)
3327 CAST_ACCESSOR(JSMessageObject) 3323 CAST_ACCESSOR(JSMessageObject)
(...skipping 1590 matching lines...) Expand 10 before | Expand all | Expand 10 after
4918 } 4914 }
4919 bool Map::IsJSGlobalProxyMap() { 4915 bool Map::IsJSGlobalProxyMap() {
4920 return instance_type() == JS_GLOBAL_PROXY_TYPE; 4916 return instance_type() == JS_GLOBAL_PROXY_TYPE;
4921 } 4917 }
4922 bool Map::IsJSGlobalObjectMap() { 4918 bool Map::IsJSGlobalObjectMap() {
4923 return instance_type() == JS_GLOBAL_OBJECT_TYPE; 4919 return instance_type() == JS_GLOBAL_OBJECT_TYPE;
4924 } 4920 }
4925 bool Map::IsJSTypedArrayMap() { return instance_type() == JS_TYPED_ARRAY_TYPE; } 4921 bool Map::IsJSTypedArrayMap() { return instance_type() == JS_TYPED_ARRAY_TYPE; }
4926 bool Map::IsGlobalObjectMap() { 4922 bool Map::IsGlobalObjectMap() {
4927 const InstanceType type = instance_type(); 4923 const InstanceType type = instance_type();
4928 return type == JS_GLOBAL_OBJECT_TYPE || type == JS_BUILTINS_OBJECT_TYPE; 4924 return type == JS_GLOBAL_OBJECT_TYPE;
4929 } 4925 }
4930 4926
4931 4927
4932 bool Map::CanOmitMapChecks() { 4928 bool Map::CanOmitMapChecks() {
4933 return is_stable() && FLAG_omit_map_checks_for_leaf_maps; 4929 return is_stable() && FLAG_omit_map_checks_for_leaf_maps;
4934 } 4930 }
4935 4931
4936 4932
4937 int DependentCode::number_of_entries(DependencyGroup group) { 4933 int DependentCode::number_of_entries(DependencyGroup group) {
4938 if (length() == 0) return 0; 4934 if (length() == 0) return 0;
(...skipping 680 matching lines...) Expand 10 before | Expand all | Expand 10 after
5619 // Never overwrite a back pointer with a constructor. 5615 // Never overwrite a back pointer with a constructor.
5620 DCHECK(!constructor_or_backpointer()->IsMap()); 5616 DCHECK(!constructor_or_backpointer()->IsMap());
5621 set_constructor_or_backpointer(constructor, mode); 5617 set_constructor_or_backpointer(constructor, mode);
5622 } 5618 }
5623 5619
5624 5620
5625 ACCESSORS(JSFunction, shared, SharedFunctionInfo, kSharedFunctionInfoOffset) 5621 ACCESSORS(JSFunction, shared, SharedFunctionInfo, kSharedFunctionInfoOffset)
5626 ACCESSORS(JSFunction, literals_or_bindings, FixedArray, kLiteralsOffset) 5622 ACCESSORS(JSFunction, literals_or_bindings, FixedArray, kLiteralsOffset)
5627 ACCESSORS(JSFunction, next_function_link, Object, kNextFunctionLinkOffset) 5623 ACCESSORS(JSFunction, next_function_link, Object, kNextFunctionLinkOffset)
5628 5624
5629 ACCESSORS(GlobalObject, builtins, JSBuiltinsObject, kBuiltinsOffset)
5630 ACCESSORS(GlobalObject, native_context, Context, kNativeContextOffset) 5625 ACCESSORS(GlobalObject, native_context, Context, kNativeContextOffset)
5631 ACCESSORS(GlobalObject, global_proxy, JSObject, kGlobalProxyOffset) 5626 ACCESSORS(GlobalObject, global_proxy, JSObject, kGlobalProxyOffset)
5632 5627
5633 ACCESSORS(JSGlobalProxy, native_context, Object, kNativeContextOffset) 5628 ACCESSORS(JSGlobalProxy, native_context, Object, kNativeContextOffset)
5634 ACCESSORS(JSGlobalProxy, hash, Object, kHashOffset) 5629 ACCESSORS(JSGlobalProxy, hash, Object, kHashOffset)
5635 5630
5636 ACCESSORS(AccessorInfo, name, Object, kNameOffset) 5631 ACCESSORS(AccessorInfo, name, Object, kNameOffset)
5637 SMI_ACCESSORS(AccessorInfo, flag, kFlagOffset) 5632 SMI_ACCESSORS(AccessorInfo, flag, kFlagOffset)
5638 ACCESSORS(AccessorInfo, expected_receiver_type, Object, 5633 ACCESSORS(AccessorInfo, expected_receiver_type, Object,
5639 kExpectedReceiverTypeOffset) 5634 kExpectedReceiverTypeOffset)
(...skipping 2492 matching lines...) Expand 10 before | Expand all | Expand 10 after
8132 #undef WRITE_INT64_FIELD 8127 #undef WRITE_INT64_FIELD
8133 #undef READ_BYTE_FIELD 8128 #undef READ_BYTE_FIELD
8134 #undef WRITE_BYTE_FIELD 8129 #undef WRITE_BYTE_FIELD
8135 #undef NOBARRIER_READ_BYTE_FIELD 8130 #undef NOBARRIER_READ_BYTE_FIELD
8136 #undef NOBARRIER_WRITE_BYTE_FIELD 8131 #undef NOBARRIER_WRITE_BYTE_FIELD
8137 8132
8138 } // namespace internal 8133 } // namespace internal
8139 } // namespace v8 8134 } // namespace v8
8140 8135
8141 #endif // V8_OBJECTS_INL_H_ 8136 #endif // V8_OBJECTS_INL_H_
OLDNEW
« src/objects.h ('K') | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698