Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: src/heap/objects-visiting-inl.h

Issue 1424703005: Remove JSBuiltinsObject. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/objects-visiting-inl.h
diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h
index ab0b357f40499c07305e9c2cd1ea6eba50ca77d4..2bf2afbb2b386b893ac11a9be73949dfaf54efb7 100644
--- a/src/heap/objects-visiting-inl.h
+++ b/src/heap/objects-visiting-inl.h
@@ -667,9 +667,8 @@ void StaticMarkingVisitor<StaticVisitor>::MarkInlinedFunctionsCode(Heap* heap,
}
-inline static bool IsValidNonBuiltinContext(Object* context) {
- return context->IsContext() &&
- !Context::cast(context)->global_object()->IsJSBuiltinsObject();
+inline static bool HasValidNonBuiltinContext(JSFunction* function) {
+ return function->context()->IsContext() && !function->IsBuiltin();
}
@@ -693,7 +692,7 @@ bool StaticMarkingVisitor<StaticVisitor>::IsFlushable(Heap* heap,
}
// The function must have a valid context and not be a builtin.
- if (!IsValidNonBuiltinContext(function->context())) {
+ if (!HasValidNonBuiltinContext(function)) {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698