test/cctest/test-heap-profiler.cc - Issue 1424703005: Remove JSBuiltinsObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 1424703005: Remove JSBuiltinsObject. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index be074f8ba8162ea80ba19c84beed2124f013114f..e05e77d2045c836a9790e880378b26874f55ad7a 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -1698,9 +1698,6 @@ TEST(GlobalObjectFields) {

const v8::HeapSnapshot* snapshot = heap_profiler->TakeHeapSnapshot();

CHECK(ValidateSnapshot(snapshot));

const v8::HeapGraphNode* global = GetGlobalObject(snapshot);

- const v8::HeapGraphNode* builtins =

- GetProperty(global, v8::HeapGraphEdge::kInternal, "builtins");

- CHECK(builtins);

const v8::HeapGraphNode* native_context =

GetProperty(global, v8::HeapGraphEdge::kInternal, "native_context");

CHECK(native_context);