Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1422703008:
telemetry_chrome_test_base should depend on dump_syms for the host toolset specifically (Closed)
|
Created:
5 years, 1 month ago by Mostyn Bramley-Moore Modified:
5 years, 1 month ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiontelemetry_chrome_test_base should depend on dump_syms for the host toolset specifically
On Linux, dump_syms is only defined for the host toolset.
Without this patch, linux gcc cross-compile builds fail
when running gyp, ever since
https://codereview.chromium.org/1419143006/ landed.
Clang builds are unaffected, because they don't have
separate host and target toolsets.
BUG=507796, 552436
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Committed: https://crrev.com/c701ba722f4c4d60b0a8fdeb9f9c3ca51da1c189
Cr-Commit-Position: refs/heads/master@{#358406}
Patch Set 1 #Patch Set 2 : rebase on master #
Messages
Total messages: 32 (13 generated)
mostynb@opera.com changed reviewers: + maruel@chromium.org, nednguyen@google.com, phajdan.jr@chromium.org
@nednguyen, maruel, Paweł: here's a possible fix for linux gcc builds after https://codereview.chromium.org/1412333004/ Without this, I get this gyp error: KeyError: '/var/lib/jenkins/workspace/chromium/src/breakpad/breakpad.gyp:dump_syms#target' I'm not yet sure how linux clang builds succeed here, since linux only defines the dump_syms target for the host toolset.
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422703008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422703008/1
Description was changed from ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset Linux only defines dump_syms for the host toolset, without this change linux gcc builds fail when running gyp. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset Linux only defines dump_syms for the host toolset, without this change linux gcc builds fail when running gyp, since https://codereview.chromium.org/1412333004/ landed. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
maruel@chromium.org changed reviewers: + thakis@chromium.org
On 2015/11/04 08:53:40, Mostyn Bramley-Moore wrote: > @nednguyen, maruel, Paweł: here's a possible fix for linux gcc builds after > https://codereview.chromium.org/1412333004/ > > Without this, I get this gyp error: > KeyError: > '/var/lib/jenkins/workspace/chromium/src/breakpad/breakpad.gyp:dump_syms#target' > > I'm not yet sure how linux clang builds succeed here, since linux only defines > the dump_syms target for the host toolset. Nico probably understands the subtlety here, which I don't. Adding him so he can confirm why there's a difference in behavior between the clang and gcc toolsets.
BTW the triggering CL might be reverted: https://codereview.chromium.org/1432653002/ - though it would still be good to figure out a fix before it relands.
On 2015/11/04 14:54:34, Mostyn Bramley-Moore wrote: > BTW the triggering CL might be reverted: > https://codereview.chromium.org/1432653002/ - though it would still be good to > figure out a fix before it relands. I am making the reland patch in https://codereview.chromium.org/1419143006/. Would love to fold this fix into that reland if possible.
On 2015/11/04 14:57:56, nednguyen wrote: > On 2015/11/04 14:54:34, Mostyn Bramley-Moore wrote: > > BTW the triggering CL might be reverted: > > https://codereview.chromium.org/1432653002/ - though it would still be good to > > figure out a fix before it relands. > > I am making the reland patch in https://codereview.chromium.org/1419143006/. > Would love to fold this fix into that reland if possible. Nvm, I think we should separate the two issues to simplify the review load.
Description was changed from ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset Linux only defines dump_syms for the host toolset, without this change linux gcc builds fail when running gyp, since https://codereview.chromium.org/1412333004/ landed. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset Linux only defines dump_syms for the host toolset, without this change linux gcc builds fail when running gyp, since https://codereview.chromium.org/1419143006/ landed. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
It looks as though this doesn't break clang builds they use the same compiler for both the host and target toolchain. So I think this change is safe.
er, I meant to say "*because* they use the same compiler ..."
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422703008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422703008/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
lgtm, sorry for the delays.
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422703008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422703008/20001
On 2015/11/04 20:44:24, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build > URL) lgtm (not an OWNER though) I just created the same change since this broken the ARM linux FYI bots: https://codereview.chromium.org/1430113003/ I believe the key is GYP_CROSSCOMPILE=1. Its trivial to repro with GYP_CROSSCOMPILE=1 ./build/gyp_chromium on any linux system.
Description was changed from ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset Linux only defines dump_syms for the host toolset, without this change linux gcc builds fail when running gyp, since https://codereview.chromium.org/1419143006/ landed. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset On Linux dump_syms is only defined for the host toolset, without this change linux gcc builds fail when running gyp, since https://codereview.chromium.org/1419143006/ landed. Clang builds are unaffected, because they don't have separate host and target toolsets. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
Description was changed from ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset On Linux dump_syms is only defined for the host toolset, without this change linux gcc builds fail when running gyp, since https://codereview.chromium.org/1419143006/ landed. Clang builds are unaffected, because they don't have separate host and target toolsets. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset On Linux, dump_syms is only defined for the host toolset. Without this patch, linux gcc cross-compile builds fail when running gyp, ever since https://codereview.chromium.org/1419143006/ landed. Clang builds are unaffected, because they don't have separate host and target toolsets. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
> lgtm (not an OWNER though) > > I just created the same change since this broken the ARM linux FYI bots: > https://codereview.chromium.org/1430113003/ > > I believe the key is GYP_CROSSCOMPILE=1. Its trivial to repro with > GYP_CROSSCOMPILE=1 ./build/gyp_chromium on any linux system. Right- reworded the description a little... @nednguyen: if your change gets reverted again, please roll this in before relanding :)
Description was changed from ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset On Linux, dump_syms is only defined for the host toolset. Without this patch, linux gcc cross-compile builds fail when running gyp, ever since https://codereview.chromium.org/1419143006/ landed. Clang builds are unaffected, because they don't have separate host and target toolsets. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset specifically On Linux, dump_syms is only defined for the host toolset. Without this patch, linux gcc cross-compile builds fail when running gyp, ever since https://codereview.chromium.org/1419143006/ landed. Clang builds are unaffected, because they don't have separate host and target toolsets. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
On 2015/11/06 19:06:42, Mostyn Bramley-Moore wrote: > > lgtm (not an OWNER though) > > > > I just created the same change since this broken the ARM linux FYI bots: > > https://codereview.chromium.org/1430113003/ > > > > I believe the key is GYP_CROSSCOMPILE=1. Its trivial to repro with > > GYP_CROSSCOMPILE=1 ./build/gyp_chromium on any linux system. > > Right- reworded the description a little... > > @nednguyen: if your change gets reverted again, please roll this in before > relanding :) Can you add my bug to this change too: https://code.google.com/p/chromium/issues/detail?id=552436
Description was changed from ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset specifically On Linux, dump_syms is only defined for the host toolset. Without this patch, linux gcc cross-compile builds fail when running gyp, ever since https://codereview.chromium.org/1419143006/ landed. Clang builds are unaffected, because they don't have separate host and target toolsets. BUG=507796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== telemetry_chrome_test_base should depend on dump_syms for the host toolset specifically On Linux, dump_syms is only defined for the host toolset. Without this patch, linux gcc cross-compile builds fail when running gyp, ever since https://codereview.chromium.org/1419143006/ landed. Clang builds are unaffected, because they don't have separate host and target toolsets. BUG=507796,552436 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
> Can you add my bug to this change too: > https://code.google.com/p/chromium/issues/detail?id=552436 Sure, done.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c701ba722f4c4d60b0a8fdeb9f9c3ca51da1c189 Cr-Commit-Position: refs/heads/master@{#358406} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
