Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1430113003:
Fix gyp crash when GYP_CROSSCOMPILE=1 (Closed)
|
Created:
5 years, 1 month ago by Sam Clegg Modified:
5 years, 1 month ago Reviewers:
M-A Ruel CC:
chromium-reviews, Roland McGrath, Mostyn Bramley-Moore, nednguyen Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix gyp crash when GYP_CROSSCOMPILE=1
A recent change broken the linux ARM cross compile FYI bot:
https://codereview.chromium.org/1419143006
breakpad.gyp:dump_syms is only available for the host
toolchain, so this change will break any build that sets
GYP_CROSSCOMPILE=1. For some reason the linux32 builders
(which run on linux64 systems) set target_arch=ia32 but
don't set GYP_CROSSCOMPILE, so this change didn't break
any builder on the main waterfall.
BUG=552436
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
Description was changed from ========== Fix gyp crash when target_arch=arm breakpad.gyp:dump_syms is only available for the host toolchain. BUG=552436 ========== to ========== Fix gyp crash when target_arch=arm This was recent broken by: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain. BUG=552436 ==========
sbc@chromium.org changed reviewers: + maruel@chromium.org
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430113003/1
Description was changed from ========== Fix gyp crash when target_arch=arm This was recent broken by: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain. BUG=552436 ========== to ========== Fix gyp crash when target_arch=arm This was recent broken by: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain, so this change will break any build that sets GYP_CROSSCOMPILE=1. For some reason the linux32 builders (which run on linux64 systems) set target_arch=ia32 but don't set GYP_CROSSCOMPILE, so this change didn't break any builder on the main waterfall. BUG=552436 ==========
Description was changed from ========== Fix gyp crash when target_arch=arm This was recent broken by: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain, so this change will break any build that sets GYP_CROSSCOMPILE=1. For some reason the linux32 builders (which run on linux64 systems) set target_arch=ia32 but don't set GYP_CROSSCOMPILE, so this change didn't break any builder on the main waterfall. BUG=552436 ========== to ========== Fix gyp crash when GYP_CROSSCOMPILE=1 This was recent broken by: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain, so this change will break any build that sets GYP_CROSSCOMPILE=1. For some reason the linux32 builders (which run on linux64 systems) set target_arch=ia32 but don't set GYP_CROSSCOMPILE, so this change didn't break any builder on the main waterfall. BUG=552436 ==========
Should have a try run of linux_arm_compile to prove it fixes it.
Description was changed from ========== Fix gyp crash when GYP_CROSSCOMPILE=1 This was recent broken by: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain, so this change will break any build that sets GYP_CROSSCOMPILE=1. For some reason the linux32 builders (which run on linux64 systems) set target_arch=ia32 but don't set GYP_CROSSCOMPILE, so this change didn't break any builder on the main waterfall. BUG=552436 ========== to ========== Fix gyp crash when GYP_CROSSCOMPILE=1 A recent change broken the linua ARM cross compile FYI bot: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain, so this change will break any build that sets GYP_CROSSCOMPILE=1. For some reason the linux32 builders (which run on linux64 systems) set target_arch=ia32 but don't set GYP_CROSSCOMPILE, so this change didn't break any builder on the main waterfall. BUG=552436 ==========
Description was changed from ========== Fix gyp crash when GYP_CROSSCOMPILE=1 A recent change broken the linua ARM cross compile FYI bot: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain, so this change will break any build that sets GYP_CROSSCOMPILE=1. For some reason the linux32 builders (which run on linux64 systems) set target_arch=ia32 but don't set GYP_CROSSCOMPILE, so this change didn't break any builder on the main waterfall. BUG=552436 ========== to ========== Fix gyp crash when GYP_CROSSCOMPILE=1 A recent change broken the linux ARM cross compile FYI bot: https://codereview.chromium.org/1419143006 breakpad.gyp:dump_syms is only available for the host toolchain, so this change will break any build that sets GYP_CROSSCOMPILE=1. For some reason the linux32 builders (which run on linux64 systems) set target_arch=ia32 but don't set GYP_CROSSCOMPILE, so this change didn't break any builder on the main waterfall. BUG=552436 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2015/11/06 18:31:30, Roland McGrath wrote: > Should have a try run of linux_arm_compile to prove it fixes it. Done
rubberstamp lgtm Mostyn had made the same CL two days ago https://codereview.chromium.org/1422703008/ but I had no clue to be able to review this. We may as well let him CQ his CL first, hey he did it first. :) But whatever, as long as the problem is fixed.
On 2015/11/06 18:41:42, M-A Ruel wrote: > rubberstamp lgtm > > Mostyn had made the same CL two days ago > https://codereview.chromium.org/1422703008/ but I had no clue to be able to > review this. > > We may as well let him CQ his CL first, hey he did it first. :) But whatever, as > long as the problem is fixed. Sure, can you LG his change then? I'll close this one. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
