Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1432653002: Revert of Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming (Closed)

Created:
5 years, 1 month ago by binjin
Modified:
5 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming (patchset #5 id:150008 of https://codereview.chromium.org/1412333004/ ) Reason for revert: Suspected to break the telemetry_perf_unittests on Mac Original issue's description: > Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming. > > This includes the reland of https://codereview.chromium.org/1423733003/ which > was reverted because it failed isolate tests with the error message > "telemetry_perf_unittests lstat /b/build/slave/Mac_Builder/build/src/out/Release/crashpad_database_util: no such file or directory" > > Fix to crashpad_database_util is in 2nd patch. (main change in chrome/chrome_tests.gypi file only, the other diff in chromium.*.json are due to adding swarming + rebase) > > * I verify on my Mac that this build crashpad_database_util: > > $ rm out/Release/crashpad_database_util > remove out/Release/crashpad_database_util? y > > $ ninja -C out/Release/ telemetry_perf_unittests > ninja: Entering directory `out/Release/' > [3/3] STAMP obj/chrome/telemetry_perf_unittests.actions_depends.stamp > > $ ls out/Release/crashpad_database_util > out/Release/crashpad_database_util > > BUG=507796 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/c3887329815bd8dc4a9c4be18c9a205520384992 > Cr-Commit-Position: refs/heads/master@{#357765} TBR=phajdan.jr@chromium.org,kbr@chromium.org,maruel@chromium.org,nednguyen@chromium.org,vadimsh@chromium.org,mostynb@opera.com,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507796 Committed: https://crrev.com/75ddb0334a052f7e24213f02c81fa9b463a3a55f Cr-Commit-Position: refs/heads/master@{#357803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -178 lines) Patch
M chrome/chrome_tests.gypi View 3 chunks +24 lines, -38 lines 0 comments Download
D chrome/telemetry_perf_unittests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 7 chunks +28 lines, -49 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +2 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +20 lines, -35 lines 0 comments Download
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 2 chunks +0 lines, -2 lines 0 comments Download
D tools/perf/perf.isolate View 1 chunk +0 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
binjin
5 years, 1 month ago (2015-11-04 12:07:23 UTC) #1
Created Revert of Run telemetry_perf_unittests via isolate on "Mac tests",
"Linux tests" and trybot with swarming

Powered by Google App Engine
This is Rietveld 408576698