Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1419143006: Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming. (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run telemetry_perf_unittests via isolate on "Mac tests", "Linux tests" and trybot with swarming. Swarming on Mac 10.9 is disabled temporarily because of crbug.com/551405 (patch 2) Swarmed telemetry_perf_unittest passed on Mac 10.6, 10.8: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/8616/steps/telemetry_perf_unittests%20on%20Mac-10.6/logs/stdio http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/10641/steps/telemetry_perf_unittests/logs/stdio This is a reland of https://codereview.chromium.org/1412333004/. Committed: https://crrev.com/3b8e8ebdd60de034d880ad05915b598a0594d7f4 Cr-Commit-Position: refs/heads/master@{#357848}

Patch Set 1 : Patch from https://codereview.chromium.org/1412333004/ #

Patch Set 2 : Disable swarming on Mac10.9Tests & Mac10.9TestDebug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -78 lines) Patch
M chrome/chrome_tests.gypi View 3 chunks +38 lines, -24 lines 0 comments Download
A chrome/telemetry_perf_unittests.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 14 chunks +49 lines, -28 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +8 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 10 chunks +29 lines, -20 lines 0 comments Download
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
A + tools/perf/perf.isolate View 1 chunk +5 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
nednguyen
5 years, 1 month ago (2015-11-04 14:47:16 UTC) #3
nednguyen
5 years, 1 month ago (2015-11-04 14:58:36 UTC) #6
M-A Ruel
lgtm
5 years, 1 month ago (2015-11-04 17:25:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419143006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419143006/20001
5 years, 1 month ago (2015-11-04 17:26:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-04 18:03:20 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3b8e8ebdd60de034d880ad05915b598a0594d7f4 Cr-Commit-Position: refs/heads/master@{#357848}
5 years, 1 month ago (2015-11-04 18:04:17 UTC) #12
cschuet (SLOW)
5 years, 1 month ago (2015-11-05 13:37:52 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1413673005/ by cschuet@chromium.org.

The reason for reverting is: speculative revert to see if it's the cause of
massive benchmarks.benchmark_smoke_unittest failures on  Mac10.9 Tests (dbg).

Powered by Google App Engine
This is Rietveld 408576698