Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1422623009: Revert of Add new, unused methods to SpdyFramerVisitorInterface. (Closed)

Created:
5 years, 1 month ago by Bence
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add new, unused methods to SpdyFramerVisitorInterface. (patchset #1 id:1 of https://codereview.chromium.org/1413683005/ ) Reason for revert: This CL broke the tree: https://build.chromium.org/p/chromium/builders/Linux/builds/68259/steps/compile/logs/stdio FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -Wl,-z,defs -pthread -Wl,-z,noexecstack -fPIC -B/b/build/slave/Linux/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -m32 -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -o flip_in_mem_edsm_server -Wl,--start-group obj/net/tools/flip_server/flip_in_mem_edsm_server.flip_in_mem_edsm_server.o obj/base/libbase.a obj/net/libflip_in_mem_edsm_server_base.a obj/net/libnet.a obj/base/libbase_static.a obj/base/allocator/liballocator_extension_thunks.a obj/third_party/modp_b64/libmodp_b64.a obj/base/third_party/dynamic_annotations/libdynamic_annotations.a obj/base/libsymbolize.a obj/base/libxdg_mime.a obj/third_party/libevent/libevent.a obj/third_party/boringssl/libboringssl.a obj/net/libbalsa.a obj/base/libbase_i18n.a obj/third_party/icu/libicui18n.a obj/third_party/icu/libicuuc.a obj/third_party/protobuf/libprotobuf_lite.a obj/url/liburl_lib.a obj/net/libnet_quic_proto.a obj/base/libbase_prefs.a obj/crypto/libcrcrypto.a obj/sdch/libsdch.a obj/third_party/zlib/libchrome_zlib.a obj/third_party/zlib/libzlib_x86_simd.a obj/build/linux/libgio.a obj/net/libepoll_server.a -Wl,--end-group -lrt -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lgconf-2 -lgio-2.0 -lresolv obj/net/libflip_in_mem_edsm_server_base.a(obj/net/tools/flip_server/flip_in_mem_edsm_server_base.spdy_interface.o):../../net/tools/flip_server/spdy_interface.cc:vtable for net::SpdySM: error: undefined reference to 'net::SpdySM::OnHeaderFrameStart(unsigned int)' obj/net/libflip_in_mem_edsm_server_base.a(obj/net/tools/flip_server/flip_in_mem_edsm_server_base.spdy_interface.o):../../net/tools/flip_server/spdy_interface.cc:vtable for net::SpdySM: error: undefined reference to 'net::SpdySM::OnHeaderFrameEnd(unsigned int, bool)' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. Original issue's description: > Add new, unused methods to SpdyFramerVisitorInterface. > > The new methods will allow SpdyFramer to pass headers to visitors through a > SpdyHeadersHandlerInterface. > > There are so many descendants of SpdyFramerVisitorInterface that I thought it > was best to start with the interface change, and add an unused stub > implementation everywhere. > > This CL lands server change 106411694 by birenroy. > > BUG=488484 > > Committed: https://crrev.com/5d0c7230e6d1e8da9597c5a967a7b92638a58442 > Cr-Commit-Position: refs/heads/master@{#357084} TBR=rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488484 Committed: https://crrev.com/fbf102ef0c0301ba9883604819006ac4fd00f885 Cr-Commit-Position: refs/heads/master@{#357093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -119 lines) Patch
M net/quic/quic_headers_stream.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 2 chunks +0 lines, -17 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +0 lines, -14 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bence
Created Revert of Add new, unused methods to SpdyFramerVisitorInterface.
5 years, 1 month ago (2015-10-30 13:45:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422623009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422623009/1
5 years, 1 month ago (2015-10-30 13:45:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422623009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422623009/1
5 years, 1 month ago (2015-10-30 13:49:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 13:55:19 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 13:55:40 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbf102ef0c0301ba9883604819006ac4fd00f885
Cr-Commit-Position: refs/heads/master@{#357093}

Powered by Google App Engine
This is Rietveld 408576698