Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: net/spdy/spdy_framer_test.cc

Issue 1422623009: Revert of Add new, unused methods to SpdyFramerVisitorInterface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_framer.h ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_framer.h" 5 #include "net/spdy/spdy_framer.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 const char* data, 92 const char* data,
93 size_t len, 93 size_t len,
94 bool fin) override { 94 bool fin) override {
95 LOG(FATAL); 95 LOG(FATAL);
96 } 96 }
97 97
98 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override { 98 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {
99 LOG(FATAL); 99 LOG(FATAL);
100 } 100 }
101 101
102 SpdyHeadersHandlerInterface* OnHeaderFrameStart(
103 SpdyStreamId stream_id) override {
104 LOG(FATAL);
105 return nullptr;
106 }
107
108 void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) override {
109 LOG(FATAL);
110 }
111
112 bool OnControlFrameHeaderData(SpdyStreamId stream_id, 102 bool OnControlFrameHeaderData(SpdyStreamId stream_id,
113 const char* header_data, 103 const char* header_data,
114 size_t len) override { 104 size_t len) override {
115 CHECK(buffer_.get() != NULL); 105 CHECK(buffer_.get() != NULL);
116 CHECK_GE(kMaxDecompressedSize, size_ + len); 106 CHECK_GE(kMaxDecompressedSize, size_ + len);
117 CHECK(!finished_); 107 CHECK(!finished_);
118 if (len != 0) { 108 if (len != 0) {
119 memcpy(buffer_.get() + size_, header_data, len); 109 memcpy(buffer_.get() + size_, header_data, len);
120 size_ += len; 110 size_ += len;
121 } else { 111 } else {
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 } 312 }
323 LOG(INFO) << "\", " << len << ")\n"; 313 LOG(INFO) << "\", " << len << ")\n";
324 } 314 }
325 315
326 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override { 316 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {
327 EXPECT_EQ(header_stream_id_, stream_id); 317 EXPECT_EQ(header_stream_id_, stream_id);
328 data_bytes_ += len; 318 data_bytes_ += len;
329 LOG(INFO) << "OnStreamPadding(" << stream_id << ", " << len << ")\n"; 319 LOG(INFO) << "OnStreamPadding(" << stream_id << ", " << len << ")\n";
330 } 320 }
331 321
332 SpdyHeadersHandlerInterface* OnHeaderFrameStart(
333 SpdyStreamId stream_id) override {
334 LOG(FATAL);
335 return nullptr;
336 }
337
338 void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) override {
339 LOG(FATAL);
340 }
341
342 bool OnControlFrameHeaderData(SpdyStreamId stream_id, 322 bool OnControlFrameHeaderData(SpdyStreamId stream_id,
343 const char* header_data, 323 const char* header_data,
344 size_t len) override { 324 size_t len) override {
345 ++control_frame_header_data_count_; 325 ++control_frame_header_data_count_;
346 CHECK_EQ(header_stream_id_, stream_id); 326 CHECK_EQ(header_stream_id_, stream_id);
347 if (len == 0) { 327 if (len == 0) {
348 ++zero_length_control_frame_header_data_count_; 328 ++zero_length_control_frame_header_data_count_;
349 // Indicates end-of-header-block. 329 // Indicates end-of-header-block.
350 headers_.clear(); 330 headers_.clear();
351 CHECK(header_buffer_valid_); 331 CHECK(header_buffer_valid_);
(...skipping 5787 matching lines...) Expand 10 before | Expand all | Expand 10 after
6139 6119
6140 EXPECT_EQ(1, visitor->data_frame_count_); 6120 EXPECT_EQ(1, visitor->data_frame_count_);
6141 EXPECT_EQ(strlen(four_score), static_cast<unsigned>(visitor->data_bytes_)); 6121 EXPECT_EQ(strlen(four_score), static_cast<unsigned>(visitor->data_bytes_));
6142 EXPECT_EQ(0, visitor->headers_frame_count_); 6122 EXPECT_EQ(0, visitor->headers_frame_count_);
6143 } 6123 }
6144 } 6124 }
6145 6125
6146 } // namespace test 6126 } // namespace test
6147 6127
6148 } // namespace net 6128 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_framer.h ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698