Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: net/spdy/buffered_spdy_framer_unittest.cc

Issue 1422623009: Revert of Add new, unused methods to SpdyFramerVisitorInterface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/mock_spdy_framer_visitor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/buffered_spdy_framer.h" 5 #include "net/spdy/buffered_spdy_framer.h"
6 6
7 #include "net/spdy/spdy_test_util_common.h" 7 #include "net/spdy/spdy_test_util_common.h"
8 #include "testing/platform_test.h" 8 #include "testing/platform_test.h"
9 9
10 namespace net { 10 namespace net {
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 const char* data, 81 const char* data,
82 size_t len, 82 size_t len,
83 bool fin) override { 83 bool fin) override {
84 LOG(FATAL) << "Unexpected OnStreamFrameData call."; 84 LOG(FATAL) << "Unexpected OnStreamFrameData call.";
85 } 85 }
86 86
87 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override { 87 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {
88 LOG(FATAL) << "Unexpected OnStreamPadding call."; 88 LOG(FATAL) << "Unexpected OnStreamPadding call.";
89 } 89 }
90 90
91 SpdyHeadersHandlerInterface* OnHeaderFrameStart(
92 SpdyStreamId stream_id) override {
93 LOG(FATAL) << "Unexpected OnHeaderFrameStart call.";
94 return nullptr;
95 }
96
97 void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) override {
98 LOG(FATAL) << "Unexpected OnHeaderFrameEnd call.";
99 }
100
101 void OnSettings(bool clear_persisted) override {} 91 void OnSettings(bool clear_persisted) override {}
102 92
103 void OnSetting(SpdySettingsIds id, uint8 flags, uint32 value) override { 93 void OnSetting(SpdySettingsIds id, uint8 flags, uint32 value) override {
104 setting_count_++; 94 setting_count_++;
105 } 95 }
106 96
107 void OnPing(SpdyPingId unique_id, bool is_ack) override {} 97 void OnPing(SpdyPingId unique_id, bool is_ack) override {}
108 98
109 void OnRstStream(SpdyStreamId stream_id, 99 void OnRstStream(SpdyStreamId stream_id,
110 SpdyRstStreamStatus status) override {} 100 SpdyRstStreamStatus status) override {}
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 reinterpret_cast<unsigned char*>(goaway_frame.get()->data()), 337 reinterpret_cast<unsigned char*>(goaway_frame.get()->data()),
348 goaway_frame.get()->size()); 338 goaway_frame.get()->size());
349 EXPECT_EQ(0, visitor.error_count_); 339 EXPECT_EQ(0, visitor.error_count_);
350 EXPECT_EQ(1, visitor.goaway_count_); 340 EXPECT_EQ(1, visitor.goaway_count_);
351 EXPECT_EQ(2u, visitor.goaway_last_accepted_stream_id_); 341 EXPECT_EQ(2u, visitor.goaway_last_accepted_stream_id_);
352 EXPECT_EQ(GOAWAY_FRAME_SIZE_ERROR, visitor.goaway_status_); 342 EXPECT_EQ(GOAWAY_FRAME_SIZE_ERROR, visitor.goaway_status_);
353 EXPECT_EQ("foo", visitor.goaway_debug_data_); 343 EXPECT_EQ("foo", visitor.goaway_debug_data_);
354 } 344 }
355 345
356 } // namespace net 346 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/mock_spdy_framer_visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698