Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: net/spdy/buffered_spdy_framer.h

Issue 1422623009: Revert of Add new, unused methods to SpdyFramerVisitorInterface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | net/spdy/buffered_spdy_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/buffered_spdy_framer.h
diff --git a/net/spdy/buffered_spdy_framer.h b/net/spdy/buffered_spdy_framer.h
index 0576f416822098248ad0165f8fe36bb81147cc23..46cda4778a24cd2bbdb85352d1fa995aef48b188 100644
--- a/net/spdy/buffered_spdy_framer.h
+++ b/net/spdy/buffered_spdy_framer.h
@@ -76,20 +76,6 @@
// |stream_id| The stream receiving data.
// |len| The number of padding octets.
virtual void OnStreamPadding(SpdyStreamId stream_id, size_t len) = 0;
-
- // Called just before processing the payload of a frame containing header
- // data. Should return an implementation of SpdyHeadersHandlerInterface that
- // will receive headers for stream |stream_id|. The caller will not take
- // ownership of the headers handler. The same instance should be returned
- // for all header frames comprising a logical header block (i.e. until
- // OnHeaderFrameEnd() is called with end_headers == true).
- virtual SpdyHeadersHandlerInterface* OnHeaderFrameStart(
- SpdyStreamId stream_id) = 0;
-
- // Called after processing the payload of a frame containing header data.
- // |end_headers| is true if there will not be any subsequent CONTINUATION
- // frames.
- virtual void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) = 0;
// Called when a SETTINGS frame is received.
// |clear_persisted| True if the respective flag is set on the SETTINGS frame.
@@ -180,9 +166,6 @@
size_t len,
bool fin) override;
void OnStreamPadding(SpdyStreamId stream_id, size_t len) override;
- SpdyHeadersHandlerInterface* OnHeaderFrameStart(
- SpdyStreamId stream_id) override;
- void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) override;
void OnSettings(bool clear_persisted) override;
void OnSetting(SpdySettingsIds id, uint8 flags, uint32 value) override;
void OnSettingsAck() override;
« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | net/spdy/buffered_spdy_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698