Issue 1421723002: Require that injected members are private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1421723002: Require that injected members are private. (Closed)

Created:
5 years, 2 months ago by Johnni Winther

Modified:
5 years, 2 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -51 lines)			Patch
M	pkg/compiler/lib/src/diagnostics/messages.dart	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/patch_parser.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/async_patch.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/collection_patch.dart	View	20 chunks	+40 lines, -40 lines	0 comments	Download
M	tests/compiler/dart2js/patch_test.dart	View	7 chunks	+62 lines, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

Johnni Winther

5 years, 2 months ago (2015-10-23 12:42:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
33109698826217014d5b35ab238795f440dafc2a (presubmit successful).