Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: pkg/compiler/lib/src/diagnostics/messages.dart

Issue 1421723002: Require that injected members are private. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/patch_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/diagnostics/messages.dart
diff --git a/pkg/compiler/lib/src/diagnostics/messages.dart b/pkg/compiler/lib/src/diagnostics/messages.dart
index ce8b6a7c0c579bca3ccf27aae87173dc00612b0d..810e88f9eb5987d2665ea407d243e04b78d09d12 100644
--- a/pkg/compiler/lib/src/diagnostics/messages.dart
+++ b/pkg/compiler/lib/src/diagnostics/messages.dart
@@ -237,6 +237,7 @@ enum MessageKind {
INHERITED_EXPLICIT_GETTER,
INHERITED_IMPLICIT_GETTER,
INHERITED_METHOD,
+ INJECTED_PUBLIC_MEMBER,
INIT_STATIC_FIELD,
INITIALIZING_FORMAL_NOT_ALLOWED,
INSTANCE_STATIC_SAME_NAME,
@@ -3329,6 +3330,10 @@ part of test.main;
"Cannot patch non-function with function patch "
"'#{functionName}'."),
+ MessageKind.INJECTED_PUBLIC_MEMBER:
+ const MessageTemplate(MessageKind.INJECTED_PUBLIC_MEMBER,
+ "Non-patch members in patch libraries must be private."),
+
MessageKind.EXTERNAL_WITH_BODY:
const MessageTemplate(MessageKind.EXTERNAL_WITH_BODY,
"External function '#{functionName}' cannot have a function body.",
« no previous file with comments | « no previous file | pkg/compiler/lib/src/patch_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698