Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: pkg/compiler/lib/src/diagnostics/messages.dart

Issue 1421723002: Require that injected members are private. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/patch_parser.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * The messages in this file should meet the following guide lines: 7 * The messages in this file should meet the following guide lines:
8 * 8 *
9 * 1. The message should be a complete sentence starting with an uppercase 9 * 1. The message should be a complete sentence starting with an uppercase
10 * letter, and ending with a period. 10 * letter, and ending with a period.
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 ILLEGAL_STATIC, 230 ILLEGAL_STATIC,
231 ILLEGAL_SUPER_SEND, 231 ILLEGAL_SUPER_SEND,
232 IMPORT_BEFORE_PARTS, 232 IMPORT_BEFORE_PARTS,
233 IMPORT_EXPERIMENTAL_MIRRORS, 233 IMPORT_EXPERIMENTAL_MIRRORS,
234 IMPORT_PART_OF, 234 IMPORT_PART_OF,
235 IMPORTED_HERE, 235 IMPORTED_HERE,
236 INHERIT_GETTER_AND_METHOD, 236 INHERIT_GETTER_AND_METHOD,
237 INHERITED_EXPLICIT_GETTER, 237 INHERITED_EXPLICIT_GETTER,
238 INHERITED_IMPLICIT_GETTER, 238 INHERITED_IMPLICIT_GETTER,
239 INHERITED_METHOD, 239 INHERITED_METHOD,
240 INJECTED_PUBLIC_MEMBER,
240 INIT_STATIC_FIELD, 241 INIT_STATIC_FIELD,
241 INITIALIZING_FORMAL_NOT_ALLOWED, 242 INITIALIZING_FORMAL_NOT_ALLOWED,
242 INSTANCE_STATIC_SAME_NAME, 243 INSTANCE_STATIC_SAME_NAME,
243 INSTANCE_STATIC_SAME_NAME_CONT, 244 INSTANCE_STATIC_SAME_NAME_CONT,
244 INTERNAL_LIBRARY, 245 INTERNAL_LIBRARY,
245 INTERNAL_LIBRARY_FROM, 246 INTERNAL_LIBRARY_FROM,
246 INVALID_ARGUMENT_AFTER_NAMED, 247 INVALID_ARGUMENT_AFTER_NAMED,
247 INVALID_AWAIT_FOR, 248 INVALID_AWAIT_FOR,
248 INVALID_BREAK, 249 INVALID_BREAK,
249 INVALID_CASE_DEFAULT, 250 INVALID_CASE_DEFAULT,
(...skipping 3072 matching lines...) Expand 10 before | Expand all | Expand 10 after
3322 MessageKind.PATCH_NON_CONSTRUCTOR: 3323 MessageKind.PATCH_NON_CONSTRUCTOR:
3323 const MessageTemplate(MessageKind.PATCH_NON_CONSTRUCTOR, 3324 const MessageTemplate(MessageKind.PATCH_NON_CONSTRUCTOR,
3324 "Cannot patch non-constructor with constructor patch " 3325 "Cannot patch non-constructor with constructor patch "
3325 "'#{constructorName}'."), 3326 "'#{constructorName}'."),
3326 3327
3327 MessageKind.PATCH_NON_FUNCTION: 3328 MessageKind.PATCH_NON_FUNCTION:
3328 const MessageTemplate(MessageKind.PATCH_NON_FUNCTION, 3329 const MessageTemplate(MessageKind.PATCH_NON_FUNCTION,
3329 "Cannot patch non-function with function patch " 3330 "Cannot patch non-function with function patch "
3330 "'#{functionName}'."), 3331 "'#{functionName}'."),
3331 3332
3333 MessageKind.INJECTED_PUBLIC_MEMBER:
3334 const MessageTemplate(MessageKind.INJECTED_PUBLIC_MEMBER,
3335 "Non-patch members in patch libraries must be private."),
3336
3332 MessageKind.EXTERNAL_WITH_BODY: 3337 MessageKind.EXTERNAL_WITH_BODY:
3333 const MessageTemplate(MessageKind.EXTERNAL_WITH_BODY, 3338 const MessageTemplate(MessageKind.EXTERNAL_WITH_BODY,
3334 "External function '#{functionName}' cannot have a function body.", 3339 "External function '#{functionName}' cannot have a function body.",
3335 options: const ["--output-type=dart"], 3340 options: const ["--output-type=dart"],
3336 howToFix: 3341 howToFix:
3337 "Try removing the 'external' modifier or the function body.", 3342 "Try removing the 'external' modifier or the function body.",
3338 examples: const [""" 3343 examples: const ["""
3339 external foo() => 0; 3344 external foo() => 0;
3340 main() => foo(); 3345 main() => foo();
3341 """, """ 3346 """, """
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
3502 static String convertToString(value) { 3507 static String convertToString(value) {
3503 if (value is ErrorToken) { 3508 if (value is ErrorToken) {
3504 // Shouldn't happen. 3509 // Shouldn't happen.
3505 return value.assertionMessage; 3510 return value.assertionMessage;
3506 } else if (value is Token) { 3511 } else if (value is Token) {
3507 value = value.value; 3512 value = value.value;
3508 } 3513 }
3509 return '$value'; 3514 return '$value';
3510 } 3515 }
3511 } 3516 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/patch_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698