Require that injected members are private.

pkg/compiler/lib/src/patch_parser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This library contains the infrastructure to parse and integrate patch files.
  *
  * Three types of elements can be patched: [LibraryElement], [ClassElement],
  * [FunctionElement]. Patches are introduced in patch libraries which are loaded
  * together with the corresponding origin library. Which libraries that are
@@ skipping 233 matching lines @@
     PatchVersion patchVersion = getPatchVersion(compiler, patch);
     if (patchVersion != null) {
       if (patchVersion.isActive(compiler.patchVersion)) {
         Element origin = enclosingClass.origin.localLookup(patch.name);
         patchElement(compiler, reporter, origin, patch);
         enclosingClass.addMember(patch, reporter);
       } else {
         // Skip this element.
       }
     } else {
+      if (Name.isPublicName(patch.name)) {
+        reporter.reportErrorMessage(patch, MessageKind.INJECTED_PUBLIC_MEMBER);
+      }
       enclosingClass.addMember(patch, reporter);
     }
   }
 }
 
 /**
  * Partial parser for patch files that also handles the members of class
  * declarations.
  */
 class PatchClassElementParser extends PartialParser {
@@ skipping 24 matching lines @@
       if (patchVersion.isActive(compiler.patchVersion)) {
         LibraryElement originLibrary = compilationUnitElement.library;
         assert(originLibrary.isPatched);
         Element origin = originLibrary.localLookup(patch.name);
         patchElement(compiler, reporter, origin, patch);
         compilationUnitElement.addMember(patch, reporter);
       } else {
         // Skip this element.
       }
     } else {
+      if (Name.isPublicName(patch.name)) {
+        reporter.reportErrorMessage(patch, MessageKind.INJECTED_PUBLIC_MEMBER);
+      }
       compilationUnitElement.addMember(patch, reporter);
     }
   }
 }
 
 void patchElement(Compiler compiler,
                   DiagnosticReporter reporter,
                   Element origin,
                   Element patch) {
   if (origin == null) {
@@ skipping 374 matching lines @@
 
 class PatchVersion {
   final String tag;
 
   const PatchVersion(this.tag);
 
   bool isActive(String patchTag) => tag == null || tag == patchTag;
 
   String toString() => 'PatchVersion($tag)';
 }